1233256 - UI icons may display as placeholder text for a split second on page load

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: logcat of issue

Description:
This is a reoccurrence of bug 1175805.

STR:
0) There are no messages in Messages app
1) Cold launch Messages app
2) Tap Gear icon on upper right

Expected: Page loads without showing weird things

Actual: The back arrow button on upper left briefly displays the word 'Left' before it shows the back arrow button.

Video showing the issue:
https://www.youtube.com/watch?v=qcQifHoRmu4

Repro rate: 4/5 if there are no messages in the app.

Also attaching a logcat.

This occurs on:
Device: Flame 2.6
BuildID: 20151216030223
Gaia: a84c2dbe672583914d04380cd61a56f1c60c3b8e
Gecko: 0babaa3edcf908c393b68a3dc2d1c2a2450c31ed
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 46.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Device: Aries 2.6
BuildID: 20151216121527
Gaia: a84c2dbe672583914d04380cd61a56f1c60c3b8e
Gecko: 0babaa3edcf908c393b68a3dc2d1c2a2450c31ed
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

Flame 2.5 is unaffected.

Device: Flame 2.5
BuildID: 20151216102959
Gaia: 062e0fa48c1b5d5156f6911a5a4519128fac3231
Gecko: ff08f85000b57964f04d4421c01784d22e0f6316
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Not nominating this to block, but lets get a window here.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.6
BuildID: 20151127081030
Gaia: 09c3d2f593799fa781b94006d3389e9cbb156c6e
Gecko: ba3bc0007148f8c2e196d2a6083f32afab8dff96
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

First Broken
Device: Flame 2.6
BuildID: 20151127091732
Gaia: 5b75fa8e7c71eca70be2c777a75e5814c88e1e14
Gecko: 3ec7c99d015079f8dc1c6466c0ef5826096790e8
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 09c3d2f593799fa781b94006d3389e9cbb156c6e
Gecko: 3ec7c99d015079f8dc1c6466c0ef5826096790e8

Last Working Gecko First Broken Gaia - repro
Gaia: 5b75fa8e7c71eca70be2c777a75e5814c88e1e14
Gecko: ba3bc0007148f8c2e196d2a6083f32afab8dff96

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/09c3d2f593799fa781b94006d3389e9cbb156c6e...5b75fa8e7c71eca70be2c777a75e5814c88e1e14

Possibly caused by changes made in Bug 1223733.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alberto this issue seems to have been caused by the changes for bug 1223733.  Can you please take a look?

Comment 6

[Wilson Page [:wilsonpage]]

This bug has happened before. It's related to the type of machine the icon-font is built on. I've got a hotfix that replaces the font with a version that has been built correctly.

We now have a Docker build setup in fxos-icons that means that we can control the build environment.

Rule of thumb: Always build fxos-icons on a linux machine.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1233256 > mozilla-b2g:master

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8699993 [details] [review]
[gaia] wilsonpage:1233256 > mozilla-b2g:master

Guillaume, I'm proposing we land this hotfix to unblock and continue the larger gaia-* -> fxos-* migration as part of bug 1229040.

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8699993 [details] [review]
[gaia] wilsonpage:1233256 > mozilla-b2g:master

That's good enough for now, but let's make sure we complete the renaming to avoid wasting time on hotfixes like this one.

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8699993 [details] [review]
[gaia] wilsonpage:1233256 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/f47eb52a85e05e4a348376b41403c9bff2f968f6

Comment 11

[Queena.Wen(Leave from Mozilla)]

Attachment: verified_Aries_KK_master.3gp

This bug has been verified as "pass" on the latest build of Aries KK master and Flame KK master 512mb by the STR in comment 0 .
- Duplicated bug 1232251 also has been verified as "pass". 

Actual result: It shows the back arrow button correctly after user taps Gear icon on the message app.
See attachment: verified_Aries_KK_master.3gp.
Reproduce rate: 0/10.

Device: Aries KK master(Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb(Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 12

[Julien Wajsberg [:julienw]]

(In reply to Wilson Page [:wilsonpage] from comment #6)
> This bug has happened before. It's related to the type of machine the
> icon-font is built on. I've got a hotfix that replaces the font with a
> version that has been built correctly.
> 
> We now have a Docker build setup in fxos-icons that means that we can
> control the build environment.
> 
> Rule of thumb: Always build fxos-icons on a linux machine.

I'm sure you explained this to me already, but why isn't the very same ttf file from fxos-icons is not flashed to the system ? Or is the issue that this ttf file has an issue that prevents the preloading from working at all ?

Comment 13

[Wilson Page [:wilsonpage]]

(In reply to Julien Wajsberg [:julienw] (PTO -> 2016) from comment #12)
> (In reply to Wilson Page [:wilsonpage] from comment #6)
> > This bug has happened before. It's related to the type of machine the
> > icon-font is built on. I've got a hotfix that replaces the font with a
> > version that has been built correctly.
> > 
> > We now have a Docker build setup in fxos-icons that means that we can
> > control the build environment.
> > 
> > Rule of thumb: Always build fxos-icons on a linux machine.
> 
> I'm sure you explained this to me already, but why isn't the very same ttf
> file from fxos-icons is not flashed to the system ? Or is the issue that
> this ttf file has an issue that prevents the preloading from working at all ?

The particular issue was related to an unknown issue in the .ttf file itself. We discovered that it must be build on a linux machine to avoid this. That is all I know :)