Closed
Bug 1233315
Opened 9 years ago
Closed 8 years ago
WorkerPushSubscription::GetKey fails
Categories
(Core :: DOM: Push Subscriptions, defect)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: mt, Unassigned)
References
Details
Attachments
(1 obsolete file)
As the label says. It always returns an empty array.
|
Reporter | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28239/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28239/
Attachment #8699355 -
Flags: review?(kcambridge)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Kit, this was a mistake on my part. I restored the test that wasn't checking this properly, so it should be OK. Of course, your big refactor will completely obliterate this.
|
||
Updated•9 years ago
|
Attachment #8699355 -
Flags: review?(kcambridge) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8699355 [details] MozReview Request: Bug 1233315 - Correct WorkerPushSubscription keys, r?kitcambridge https://reviewboard.mozilla.org/r/28239/#review25325 Thanks for the catch! You're right; I think this is fixed by bug 1189998. Want to rebase the changes to `PushCrypto.jsm` and the test, or just close this out?
|
|
Reporter | |
Comment 4•8 years ago
|
||
Let's leave this to bug 1189998
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8699355 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•