|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
53.47 KB, text/x-log
MozReview Request: Bug 1233369 - UnifiedComplete.js calls TelemetryStopwatch.finish() for PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS multiple times. r=adw
58 bytes, text/x-review-board-request
|Details | Review|
Hi Georg! I failed the bug on PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS.
Paolo, hg history shows you and Marco having worked around there: https://hg.mozilla.org/mozilla-central/annotate/0babaa3edcf908c393b68a3dc2d1c2a2450c31ed/toolkit/components/places/UnifiedComplete.js#l1332 Can you look into this?
Flags: needinfo?(gfritzsche) → needinfo?(paolo.mozmail)
so we are changing the TelemetryStopWatch API? The bug here is actually something we did ON PURPOSE since the API was designed to allow calling finish multiple times as a no-op. In some cases avoiding a double call complicates the code and the benefit looks low (what is exactly? just linting?)
Priority: -- → P2
Hi Marco! We are extending TelemetryStopwatch API to handle keyed histograms. Existing API will keep working as it used to. Finishing a non-existing timer will still be no-op, but this event is now logged with Cu.reportError(). We believe that this could be helpful for catching unintentional mistakes. This will not affect your code more than an error showing up in console and logs. If you are ok with this, feel free to close this bug. We filed it to make sure nothing is (or was) broken. Also, the code in Bug 1205898 has not landed yet, so we can still add/change something without much headache. But lets discuss possible changes there. How does this sound?
I think we can fix it to avoid the console spew. I'm happy the error is not propagated but just reported.
Duplicate of this bug: 1235553
mak: any chance you could take this, or know someone that you could assign it to? Bug 1205898 has landed now (which turns this bug into consolespew per comment 4), and the resulting consolespew is pretty bad. In my case, it seems like the warning from comment 0 gets spammed to Browser Console once per character I type in my URLbar, approximately.
Assignee: nobody → mak77
Created attachment 8707529 [details] MozReview Request: Bug 1233369 - UnifiedComplete.js calls TelemetryStopwatch.finish() for PLACES_AUTOCOMPLETE_1ST_RESULT_TIME_MS multiple times. r=adw Review commit: https://reviewboard.mozilla.org/r/30745/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30745/
Attachment #8707529 - Flags: review?(adw)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.