tabbed browser calls onLinkIconAvailable not defined on nsIProgressMeter

RESOLVED FIXED

Status

--
major
RESOLVED FIXED
17 years ago
11 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

Bug Flags:
blocking-aviary1.0 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

17 years ago
tabbrowser.xml lines 377 and 468 calls the undeclared onLinkIconAvailable method
on registered nsIProgressListeners. However the only actual implementation
happens to be in nsBrowserStatusHandler.js, so any other progress listeners
could cause unintentional tabbed browsing errors, e.g. preventing title bar updates.

Comment 1

17 years ago
-> future
Target Milestone: --- → Future
QA Contact: sairuh → pmac

Comment 2

15 years ago
this makes it nearly impossible to debug our code because we constantly hit this
error. and since it's in xbl we can't tell venkman to ignore the problem.
Assignee: jag → timeless
Severity: minor → major
Target Milestone: Future → ---

Comment 3

15 years ago
Seeing this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3)
Gecko/20040903 Firefox/1.0 PR (NOT FINAL), so it's not Windows95-only problem ;)

I beg of you, *please* fix it for 1.0, since there are a few firefox extensions
that register progress listeners, without onLinkIconAvailable, as it's not in
the interface. That results in pages without icons [at least under certain
circumstances], a highly visible bug.

Am I completely misguided thinking that a simple try{}catch block will solve the
problem for the time being?
Maybe a better way would be to have an additional interface inheriting from
nsIProgressListener (or whatever) with the onLinkIconAvailable() method, but the
try{}catch doesn't seem to be evil.


Summing up:
- will a patch surrounding the onLinkIconAvailable() calls with try{}catch be
accepted;
- if not, what is supposed to be done here;
- any chances that it will make its way into 1.0 (otherwise I'll try to inform
extension makers about the bug, so they can work it around by 1.0, as some have
already done)

Thanks.
Flags: blocking-aviary1.0?

Updated

15 years ago
Flags: blocking-aviary1.0? → blocking-aviary1.0-

Comment 4

14 years ago
Created attachment 168082 [details] [diff] [review]
while i'm waiting for neil to fix the api

Updated

14 years ago
Attachment #168082 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #168082 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

14 years ago
Attachment #168082 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 168082 [details] [diff] [review]
while i'm waiting for neil to fix the api

r=bzbarsky
Attachment #168082 - Flags: review?(neil.parkwaycc.co.uk) → review+

Comment 6

14 years ago
Comment on attachment 168082 [details] [diff] [review]
while i'm waiting for neil to fix the api

mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml	1.107
mozilla/toolkit/content/widgets/tabbrowser.xml	1.62
Attachment #168082 - Attachment is obsolete: true

Updated

14 years ago
Assignee: timeless → neil.parkwaycc.co.uk

Comment 7

14 years ago
Requesting that this patch land on the aviary branch.  It's a small, safe patch
which should fix lots of problems I've been seeing Firefox users experience
(fast find stops working, window title does not update when a tab is closed, etc.)
Flags: blocking-aviary1.0.3?
OS: Windows 95 → All
Hardware: PC → All

Comment 8

14 years ago
possibly related note:
 * bug 250423 has to do with window titlebar not updating (it has 20 duplicates
of which some seem related)

Updated

14 years ago
Flags: blocking-aviary1.0.3?

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.