1233415 - Share icon from action bar is misaligned on some devices on landscape

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: device-2015-12-17-154407.png

Device: ZTE x86 (Android 4.0.4), Alcatel One Touch (Android 4.1.2)

Steps to reproduce:
1. Load a page
2. Long tap on a word

Expected result:
- The icons from action bar are correctly aligned.

Actual result:
- Share icon is misaligned.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Teodora, which class of devices does this occur on (e.g. 7" tablets, 10" tablets, phones)? Is it mixed?

I think this could be related to removing the whitespace from various icons in the UI.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

I could reproduce the issue on:
Alcatel OT-8008D: 5.0"
Prestigio  PSP5508DUO: 5.0'"
ZTE Grand X: 4.3"
Motorola X: 4.7"

I could not reproduce the issue on:
Nexus 6: 5.96"
Samsung S6 Edge: 5.1"

Comment 3

[:Margaret Leibovic]

This looks pretty bad, we should fix this at some point, maybe as part of a polish sprint.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

How this can be tested without owning one of those devices? Is the emulator enough for trying?

Comment 5

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #4)
> How this can be tested without owning one of those devices? Is the emulator
> enough for trying?

It might be – best thing to do is try it out! :)

Comment 6

[Tom Klein]

Attachment: Bug 1233415 - Make action bar actions full action bar height.

Review commit: https://reviewboard.mozilla.org/r/103090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103090/

Comment 7

[Tom Klein]

Attachment: Share button is less than full height

I'm able to reproduce on a Nexus 5 emulator in landscape mode.

That's an interesting path to add action items to the action bar :)

The "Share" icon is wider than tall, whereas the other action icons are square.  I don't understand why that only causes the Share icon to be too short in landscape mode on certain phones (internal layout calculations I guess?), but setting layout_height="match_parent" on the action view seems to fix it.

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8824814 [details]
Bug 1233415 - Make action bar actions full action bar height.

https://reviewboard.mozilla.org/r/103090/#review104248

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edcbb6e741c9
Make action bar actions full action bar height. r=sebastian

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edcbb6e741c9