1233447 - removeTrack throwing NS_ERROR_UNEXPECTED error

Status: RESOLVED DUPLICATE of bug 1133874

(Core :: WebRTC, defect)

Description

[Balwant Bisht]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151214004008

Steps to reproduce:

Replace audio stream e.g mic gain stream, using removeTrack & addTrack of peerconnection


Actual results:

Firefox throwing error when removeTrack is called

Exception... "Unexpected error"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"

As removeTrack not able to remove audio track, multiple audio track gets added to peerconnection and both audio tracks sending media to server


Expected results:

Audio track should be removed from peerconnection

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Please provide more info - code snippets or a working example (preferably).  We support removeTrack() and have tests in our tree for various aspects of it.

What version of Firefox were you using?  44? (which was used to file the bug)

Comment 2

[Andreas Pehrson [:pehrsons]]

Just looking at possible paths for RTCPeerConnection::RemoveTrack I do see one that throws NS_ERROR_UNEXPECTED: [1]

It is in jsep, with the following internal message: "Removing tracks outside of stable is unsupported."


[1] https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp#134

Comment 3

[Maire Reavy [:mreavy]]

Resolving this as incomplete due to lack of response on needinfo from January.  We can reopen if we get more info and the problem is still happening for the reporter.

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I was able to reproduce it in this fiddle:

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #2)
> It is in jsep, with the following internal message: "Removing tracks outside
> of stable is unsupported."

The spec [1] makes no mention of not supporting removeTrack outside of stable state (except closed). Do we plan to support this?

If yes, then great. If no, then we can test for this state and throw a nicer error in PeerConnection.js.

[1] http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-removetrack

Comment 6

[Byron Campen [:bwc]]

Yeah, this is a known limitation. I can either mark this as a dupe of bug 1133874, or we can keep this open for throwing a nicer error.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Dup wfm.