1233459 - If a user manually reinstalls an add-on we should drop the foreignInstall flag

Status: REOPENED

(Toolkit :: Add-ons Manager, defect, P4)

Description

[Dave Townsend [:mossop]]

When we detect an add-on as sideloaded we mark foreignInstall to true and as updates are installed automatically we maintain that under the assumption that once sideloaded always sideloaded. The exception should be that if a user manually installs the same add-on from the web then we should drop the foreignInstall flag but we don't right now.

This can cause problems if add-ons are only preliminarily signed but were once sideloaded somehow, users will have to completely uninstall then install the add-on to drop the foreignInstall flag.

Comment 1

[Andrew Zitnay]

Any movement on this?  It's definitely confusing.  Even more confusing is the fact that the extension remains enabled for some period of time, even though it says it's disabled, but then randomly gets disabled at some point in the future.

Comment 2

[Andy McKay]

If bug 1245956 happens, then this will be irrelevant.

Comment 3

[Dave Townsend [:mossop]]

(In reply to Andy McKay [:andym] from comment #2)
> If bug 1245956 happens, then this will be irrelevant.

I disagree, this flag still has uses even if just for metrics.

Comment 4

[Andy McKay]

Fair enough, removed from blocking signing though.

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.