Pre-land strings required for Touch ID/Passcode management

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sleroux, Assigned: sleroux)

Tracking

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios2.0+)

Details

(Whiteboard: [needstrings])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Bug to track landing strings for the Touch ID/passcode managers.
(Assignee)

Comment 1

2 years ago
Created attachment 8699562 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1368
Attachment #8699562 - Flags: review?(rnewman)
Attachment #8699562 - Flags: review?(randersen)
Comment on attachment 8699562 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1368

Line #74
 let useTouchID = NSLocalizedString("Use Touch ID For:", tableName:  "AuthenticationManager", comment: "List section title for when to use touch ID")

Should be:
"Use Touch ID for" 
lower case f in 'for', no colon.

"List section title for when to use Touch ID"
Capitalize T in 'touch'.
Comment on attachment 8699562 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1368

r+ with Robin's comments addressed.
Attachment #8699562 - Flags: review?(rnewman) → review+
(Assignee)

Comment 4

2 years ago
Landed

Master a11f0c93fedc84776d14677a9354a6cb01d4d1a5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Attachment #8699562 - Flags: review?(randersen) → review+

Updated

2 years ago
Depends on: 1235608
You need to log in before you can comment on or make changes to this bug.