Firefox shouldn’t change tab title to “Connecting…” when restoring pending tab

NEW
Unassigned

Status

()

Firefox
Tabbed Browser
2 years ago
2 years ago

People

(Reporter: tabmix.onemen, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
when selecting a pending tab, the tab title change to Connecting… for a split second.

there is no reason to change the title to Connecting… when restoring a pending tab

Comment 1

2 years ago
(In reply to tabmix.onemen from comment #0)
> when selecting a pending tab, the tab title change to Connecting… for a
> split second.
> 
> there is no reason to change the title to Connecting… when restoring a
> pending tab

I'm a little confused - don't we request data from the server for the HTML of the toplevel page for these tabs? So why isn't "Connecting..." correct?
Flags: needinfo?(tabmix.onemen)
(Reporter)

Comment 2

2 years ago
I didn't say that it is not correct, i say it is not necessary.

the tab title already set before by SessionStore, and the page content get loaded from cache most of the time for restored tab (as far as i know)

If you look at the title you will just see it flicker for a moment
(Reporter)

Comment 3

2 years ago
Do you need any more information from me?

Comment 4

2 years ago
(In reply to tabmix.onemen from comment #3)
> Do you need any more information from me?

Well, it depends...

I *think*, but I could be wrong, that pages don't always load from cache, especially no-cache SSL pages might not, I would expect. But I don't believe there's any way for the frontend to know if we're going to be doing "actual" network access or not, and leaving the page title there and no indication that we're "connecting" when we are in fact waiting for the network and showing a blank content area seems wrong. Am I wrong and/or misunderstanding your request?

Mike, do you know something about the session store aspect of this?
Flags: needinfo?(mconley)
(In reply to :Gijs Kruitbosch from comment #4)
> 
> Mike, do you know something about the session store aspect of this?

I can't think of a good reason to hide the tab title with Connecting for this case, tbh - if the tab title _is_ out of date, then when the document loads, I believe a DOMTitleChanged event will be fired in any case, and the parent will be notified to update.
Flags: needinfo?(mconley)
(Reporter)

Updated

2 years ago
Flags: needinfo?(tabmix.onemen)
You need to log in before you can comment on or make changes to this bug.