1233506 - Malformed 'mach try' produced unexpected results

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

In this try push, I neglected the '-b' flag. Jobs started, but with crazy options!

$ ./mach try do -p emulator,android-x86,android-api-9,android-api-11 -u all -t none
mach try is under development, please file bugs blocking 1149670.
From _tests: Kept 37308 existing; Added/updated 0; Removed 0 files and 0 directories.
Creating temporary commit for remote...
pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets                                                                                                           
remote: adding manifests
remote: adding file changes
remote: added 3 changesets with 2 changes to 3 files (+1 heads)
remote: recorded push in pushlog
remote: legacy replication of changegroup disabled because vcsreplicator is loaded
remote: 
remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/091d6abe18cf
remote:   https://hg.mozilla.org/try/rev/e1fdfde5c95d
remote:   https://hg.mozilla.org/try/rev/185750de4d95
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=185750de4d95
remote: recorded changegroup in replication log in 0.018s
push complete
temporary commit removed, repository restored


https://hg.mozilla.org/try/rev/185750de4d95 shows:

try: -b do -p android-api-9,android-api-11,android-x86,emulator -u all,crashtest,crashtest-e10s,mochitest-1,mochitest-browser-chrome-1,mochitest-e10s-1,mochitest-e10s-browser-chrome-1,mochitest-o,reftest,reftest-e10s,xpcshell -t none --try-test-paths browser-chrome:docshell/test/browser browser-chrome:docshell/test/navigation browser-chrome:dom/base/test browser-chrome:dom/cache/test/mochitest browser-chrome:dom/html/test browser-chrome:dom/indexedDB/test browser-chrome:dom/ipc/tests browser-chrome:dom/manifest/test browser-chrome:dom/power/test browser-chrome:dom/security/test/csp browser-chrome:dom/tests/browser browser-chrome:dom/workers/test browser-chrome:dom/workers/test/serviceworkers chrome:docshell/test/chrome chrome:dom/activities/tests/mochi chrome:dom/animation/test/chrome chrome:dom/apps/tests chrome:dom/base/test chrome:dom/base/test/chrome chrome:dom/bindings/test chrome:dom/broadcastchannel/tests chrome:dom/browser-element/mochitest chrome:dom/cache/test/mochitest chrome:dom/canvas/test/chrome chrome:dom/devicestorage/test chrome:dom/encoding/test chrome:dom/events/test chrome:dom/html/test chrome:dom/html/test/forms chrome:dom/indexedDB/test chrome:dom/ipc/tests chrome:dom/media/test chrome:dom/media/webaudio/test chrome:dom/messagechannel/tests chrome:dom/messages/test chrome:dom/network/tests chrome:dom/phonenumberutils/tests chrome:dom/promise/tests chrome:dom/security/test/csp chrome:dom/system/tests chrome:dom/tests/mochitest/beacon chrome:dom/tests/mochitest/chrome chrome:dom/tests/mochitest/general chrome:dom/tests/mochitest/localstorage chrome:dom/tests/mochitest/sessionstorage chrome:dom/tests/mochitest/webapps chrome:dom/tests/mochitest/whatwg chrome:dom/workers/test chrome:dom/workers/test/serviceworkers chrome:dom/xbl/test chrome:dom/xul/templates/tests/chrome chrome:dom/xul/test crashtest:docshell/base/crashtests crashtest:dom/audiochannel/crashtests crashtest:dom/base/crashtests crashtest:dom/bindings/crashtests crashtest:dom/canvas/crashtests crashtest:dom/events/crashtests crashtest:dom/html/crashtests crashtest:dom/indexedDB/crashtests crashtest:dom/jsurl/crashtests crashtest:dom/mathml/crashtests crashtest:dom/media/mediasource/test/crashtests crashtest:dom/media/test/crashtests crashtest:dom/media/tests/crashtests crashtest:dom/offline/crashtests crashtest:dom/plugins/test/crashtests crashtest:dom/smil/crashtests crashtest:dom/svg/crashtests crashtest:dom/workers/test/crashtests crashtest:dom/xbl/crashtests crashtest:dom/xml/crashtests crashtest:dom/xslt/crashtests crashtest:dom/xul/crashtests crashtest:dom/xul/templates/crashtests mochitest:docshell/test mochitest:docshell/test/iframesandbox mochitest:docshell/test/navigation mochitest:dom/alarm/test mochitest:dom/animation/test/css-animations mochitest:dom/animation/test/css-transitions mochitest:dom/animation/test/document-timeline mochitest:dom/animation/test/mozilla mochitest:dom/apps/tests mochitest:dom/archivereader/test mochitest:dom/asmjscache/test mochitest:dom/base/test mochitest:dom/base/test/websocket_hybi mochitest:dom/battery/test mochitest:dom/bindings/test mochitest:dom/broadcastchannel/tests mochitest:dom/browser-element/mochitest mochitest:dom/browser-element/mochitest/priority mochitest:dom/cache/test/mochitest mochitest:dom/canvas/test mochitest:dom/canvas/test/crossorigin mochitest:dom/canvas/test/webgl-conformance/_wrappers mochitest:dom/canvas/test/webgl-mochitest mochitest:dom/crypto/test mochitest:dom/datastore/tests mochitest:dom/devicestorage/test mochitest:dom/encoding/test mochitest:dom/events/test mochitest:dom/html/test mochitest:dom/html/test/forms mochitest:dom/html/test/imports mochitest:dom/imptests/editing/conformancetest mochitest:dom/imptests/editing/selecttest mochitest:dom/imptests/failures/editing/conformancetest mochitest:dom/imptests/failures/editing/selecttest mochitest:dom/imptests/failures/html/dom mochitest:dom/imptests/failures/html/dom/errors mochitest:dom/imptests/failures/html/dom/lists mochitest:dom/imptests/failures/html/dom/nodes mochitest:dom/imptests/failures/html/dom/ranges mochitest:dom/imptests/failures/html/html/browsers/the-window-object mochitest:dom/imptests/failures/html/html/browsers/the-window-object/named-access-on-the-window-object mochitest:dom/imptests/failures/html/html/dom/documents/dta mochitest:dom/imptests/failures/html/html/dom/documents/dta/doc.gEBN mochitest:dom/imptests/failures/html/html/obsolete/implreq/oeaaa mochitest:dom/imptests/failures/html/html/semantics/forms/the-select-element mochitest:dom/imptests/failures/html/html/semantics/scripting-1/the-script-element mochitest:dom/imptests/failures/html/html/semantics/tabular-data/the-table-element mochitest:dom/imptests/failures/html/html/webappapis/atob mochitest:dom/imptests/failures/html/js/builtins mochitest:dom/imptests/failures/html/microdata/microdata-dom-api mochitest:dom/imptests/failures/html/typedarrays mochitest:dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware mochitest:dom/imptests/html/dom mochitest:dom/imptests/html/dom/collections mochitest:dom/imptests/html/dom/errors mochitest:dom/imptests/html/dom/events mochitest:dom/imptests/html/dom/lists mochitest:dom/imptests/html/dom/nodes mochitest:dom/imptests/html/dom/ranges mochitest:dom/imptests/html/dom/traversal mochitest:dom/imptests/html/domxpath mochitest:dom/imptests/html/html/browsers/browsing-the-web/read-media mochitest:dom/imptests/html/html/browsers/the-window-object mochitest:dom/imptests/html/html/browsers/the-window-object/named-access-on-the-window-object mochitest:dom/imptests/html/html/dom/documents/dta mochitest:dom/imptests/html/html/dom/documents/dta/doc.gEBN mochitest:dom/imptests/html/html/dom/elements/global-attributes mochitest:dom/imptests/html/html/obsolete/implreq/oeaaa mochitest:dom/imptests/html/html/semantics/document-metadata/the-title-element mochitest:dom/imptests/html/html/semantics/forms/the-form-element mochitest:dom/imptests/html/html/semantics/forms/the-option-element mochitest:dom/imptests/html/html/semantics/forms/the-select-element mochitest:dom/imptests/html/html/semantics/scripting-1/the-script-element mochitest:dom/imptests/html/html/semantics/tabular-data/the-table-element mochitest:dom/imptests/html/html/semantics/text-level-semantics/the-time-element mochitest:dom/imptests/html/html/webappapis/atob mochitest:dom/imptests/html/html/webappapis/scripting/events mochitest:dom/imptests/html/html/webappapis/scripting/processing-model-2 mochitest:dom/imptests/html/html/webappapis/timers mochitest:dom/imptests/html/js/builtins mochitest:dom/imptests/html/microdata/microdata-dom-api mochitest:dom/imptests/html/typedarrays mochitest:dom/imptests/html/webgl mochitest:dom/imptests/webapps/WebStorage/tests/submissions/Infraware mochitest:dom/imptests/webapps/WebStorage/tests/submissions/Ms2ger mochitest:dom/imptests/webapps/XMLHttpRequest/tests/submissions/Ms2ger mochitest:dom/indexedDB/test mochitest:dom/inputmethod/mochitest mochitest:dom/inputport/test/mochitest mochitest:dom/ipc/tests mochitest:dom/json/test mochitest:dom/jsurl/test mochitest:dom/manifest/test mochitest:dom/media/mediasource/test mochitest:dom/media/test mochitest:dom/media/tests/mochitest mochitest:dom/media/tests/mochitest/identity mochitest:dom/media/tests/mochitest/ipc mochitest:dom/media/webaudio/test mochitest:dom/media/webspeech/recognition/test mochitest:dom/media/webspeech/synth/test mochitest:dom/messagechannel/tests mochitest:dom/messages/test mochitest:dom/mobileconnection/tests/mochitest mochitest:dom/mobilemessage/tests/mochitest mochitest:dom/network/tests mochitest:dom/payment/tests/mochitest mochitest:dom/permission/tests mochitest:dom/phonenumberutils/tests mochitest:dom/power/test mochitest:dom/presentation/tests/mochitest mochitest:dom/promise/tests mochitest:dom/push/test mochitest:dom/requestsync/tests mochitest:dom/resourcestats/tests/mochitest mochitest:dom/security/test/cors mochitest:dom/security/test/csp mochitest:dom/security/test/mixedcontentblocker mochitest:dom/security/test/sri mochitest:dom/settings/tests mochitest:dom/smil/test mochitest:dom/svg/test mochitest:dom/system/tests mochitest:dom/tests/mochitest/ajax/jquery mochitest:dom/tests/mochitest/ajax/mochikit mochitest:dom/tests/mochitest/ajax/offline mochitest:dom/tests/mochitest/ajax/prototype mochitest:dom/tests/mochitest/ajax/scriptaculous mochitest:dom/tests/mochitest/beacon mochitest:dom/tests/mochitest/bugs mochitest:dom/tests/mochitest/crypto mochitest:dom/tests/mochitest/dom-level0 mochitest:dom/tests/mochitest/dom-level1-core mochitest:dom/tests/mochitest/dom-level2-core mochitest:dom/tests/mochitest/dom-level2-html mochitest:dom/tests/mochitest/fetch mochitest:dom/tests/mochitest/gamepad mochitest:dom/tests/mochitest/general mochitest:dom/tests/mochitest/geolocation mochitest:dom/tests/mochitest/localstorage mochitest:dom/tests/mochitest/notification mochitest:dom/tests/mochitest/orientation mochitest:dom/tests/mochitest/pointerlock mochitest:dom/tests/mochitest/sessionstorage mochitest:dom/tests/mochitest/storageevent mochitest:dom/tests/mochitest/webapps mochitest:dom/tests/mochitest/webcomponents mochitest:dom/tests/mochitest/whatwg mochitest:dom/tv/test/mochitest mochitest:dom/workers/test mochitest:dom/workers/test/serviceworkers mochitest:dom/xbl/test mochitest:dom/xml/test mochitest:dom/xslt/tests/mochitest mochitest:dom/xul/test reftest:dom/canvas/test/reftest reftest:dom/encoding/test/reftest reftest:dom/html/reftests reftest:dom/html/reftests/autofocus reftest:dom/html/reftests/toblob-todataurl reftest:dom/imptests/html/html/dom/elements/global-attributes reftest:dom/imptests/html/html/editing/the-hidden-attribute reftest:dom/plugins/test/reftest reftest:dom/tests/reftest reftest:dom/tests/reftest/xml-stylesheet xpcshell:docshell/test/unit xpcshell:docshell/test/unit_ipc xpcshell:dom/activities/tests/unit xpcshell:dom/alarm/test xpcshell:dom/apps/tests/unit xpcshell:dom/base/test/unit xpcshell:dom/base/test/unit_ipc xpcshell:dom/cache/test/xpcshell xpcshell:dom/encoding/test/unit xpcshell:dom/indexedDB/test/unit xpcshell:dom/inputport/test/xpcshell xpcshell:dom/json/test/unit xpcshell:dom/mobilemessage/tests/xpcshell xpcshell:dom/newapps/test/xpcshell xpcshell:dom/notification/test/unit xpcshell:dom/payment/tests/unit xpcshell:dom/permission/tests/unit xpcshell:dom/plugins/test/unit xpcshell:dom/presentation/tests/xpcshell xpcshell:dom/promise/tests/unit xpcshell:dom/push/test/xpcshell xpcshell:dom/security/test/unit xpcshell:dom/settings/tests/unit xpcshell:dom/tests/unit xpcshell:dom/tv/test/xpcshell xpcshell:dom/workers/test/xpcshell 


Note the reftest failures, which seem to be related.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

It looks like we're taking "do" as a positional argument and finding every test whose path begins with "do" (the result is about what I would expect in that case). Probably we should bail out if a positional argument isn't actually a directory, I don't think running random prefixes is that useful.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1233506 - Only accept positional arguments to mach try that are directories. r=jgraham

Review commit: https://reviewboard.mozilla.org/r/28289/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28289/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

With this patch I get:

$ ./mach try do -p emulator,android-x86,android-api-9,android-api-11 -u all -t none --no-push
mach try is under development, please file bugs blocking 1149670.
Specified path "/home/chris/m-c/do" is not a directory under the srcdir, unable to specify tests outside of the srcdir

which doesn't point to the exact problem, but might ultimately surface the problem.

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8699592 [details]
MozReview Request: Bug 1233506 - Only accept positional arguments to mach try that are directories. r=jgraham

https://reviewboard.mozilla.org/r/28289/#review25367

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfa47883e492

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cfa47883e492