1233527 - Intermittent TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_uninstall_test.js | Homescreen - Pinned Site Uninstall "before each" hook for "removal of pinned site"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [screenshot] failure state

TEST-UNEXPECTED-FAIL | apps/homescreen/test/marionette/pinning_uninstall_test.js | Homescreen - Pinned Site Uninstall "before each" hook for "removal of pinned site"
Error: timeout exceeded!
    at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
    at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
    at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
    at Object.pinDialog (apps/system/test/marionette/lib/pinning_the_web.js:21:31)
    at Object.openAndPinSite [as openAndPinSiteFromBrowser] (apps/system/test/marionette/lib/pinning_the_web.js:77:54)
    at Context.<anonymous> (apps/homescreen/test/marionette/pinning_uninstall_test.js:41:13)
    at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
    at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

disabled in master: https://github.com/mozilla-b2g/gaia/commit/a43d2a8faff0e04b56206582c905b1fd47e79216

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1233527-intermittent-pinning_uninstall_test > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8706390 [details] [review]
[gaia] gmarty:Bug-1233527-intermittent-pinning_uninstall_test > mozilla-b2g:master

I believe this test is now more stable thanks to the changes in waitForLaunch().
No failures in ~50 tries.

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8706390 [details] [review]
[gaia] gmarty:Bug-1233527-intermittent-pinning_uninstall_test > mozilla-b2g:master

Looks good - might be worth renaming the commit, it seems the log scanners pick up the commit message as a failure when other tests fail?

Comment 5

[Guillaume Marty [:gmarty]]

Landed in https://github.com/mozilla-b2g/gaia/commit/90bd71643b35f254ff0c54b0237808a280a8b7d6