Closed Bug 1233542 Opened 4 years ago Closed 4 years ago

re-export variables prior to running JS subconfigure

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

We need to do this for the same reason we do it for ICU: msys messues
with environment variables (as suggested in build/subconfigure.py).
This change (or something like it) is needed to build with clang-cl.  Without
this change, js/src/ doesn't see a toplevel CXX=clang-cl setting, and gets
compiled with cl instead, leading to...problems.

Without this patch, a clang-cl-compiled browser crashes on startup.  With this
patch...things still crash, but at least clang-cl is getting used for the JS
source files!
Attachment #8699628 - Flags: review?(mh+mozilla)
Blocks: winclang
Comment on attachment 8699628 [details] [diff] [review]
re-export variables prior to running JS subconfigure

Review of attachment 8699628 [details] [diff] [review]:
-----------------------------------------------------------------

meh
Attachment #8699628 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d8e260e1535f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.