1233549 - Disallow ES3 compressed texture formats

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Disallow ES3 compressed texture formats

This fixes assertion failures on platforms that don't have these formats. This is a temporary fix until we iron out this issue in the spec. It's easier to add this later than it is to take it away.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8699624 [details] [diff] [review]
Disallow ES3 compressed texture formats

Review of attachment 8699624 [details] [diff] [review]:
-----------------------------------------------------------------

Wrong patch.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Disallow ES3 compressed texture formats

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8699793 [details] [diff] [review]
Disallow ES3 compressed texture formats

Review of attachment 8699793 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFormats.cpp
@@ +88,5 @@
>  InitCompressedFormatInfo()
>  {
>      // GLES 3.0.4, p147, table 3.19
>      // GLES 3.0.4, p286+, $C.1 "ETC Compressed Texture Image Formats"
> +#if ALLOW_ES3_FORMATS

Don't ifdef off these.

@@ +249,5 @@
>      AddFormatInfo(FOO(STENCIL_INDEX8), 1, UnsizedFormat::S, false, ComponentType::UInt);
>  
>      // GLES 3.0.4, p147, table 3.19
>      // GLES 3.0.4  p286+  $C.1 "ETC Compressed Texture Image Formats"
> +#if ALLOW_ES3_FORMATS

Don't ifdef off these.

@@ +784,5 @@
>      fnAllowES3TexFormat(FOO(DEPTH32F_STENCIL8 ), true, false);
>  
>      // GLES 3.0.4, p147, table 3.19
>      // GLES 3.0.4, p286+, $C.1 "ETC Compressed Texture Image Formats"
> +#if ALLOW_ES3_FORMATS

Only ifdef off these.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Disallow ES3 compressed texture formats

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1e0539dd11e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e1e0539dd11e

Comment 7

[Ethan Lin[:ethlin]]

Hi Jeff,
I would like to do the following work of the compressed texture. If you are working on it, I will skip it to avoid duplicating work.

Comment 8

[Kelsey Gilbert [:jgilbert]]

(In reply to Ethan Lin[:ethlin] from comment #7)
> Hi Jeff,
> I would like to do the following work of the compressed texture. If you are
> working on it, I will skip it to avoid duplicating work.

Create a new bug and cc us, so we can talk about the path forward there.

Comment 9

[Ethan Lin[:ethlin]]

(In reply to Jeff Gilbert [:jgilbert] from comment #8)
> (In reply to Ethan Lin[:ethlin] from comment #7)
> > Hi Jeff,
> > I would like to do the following work of the compressed texture. If you are
> > working on it, I will skip it to avoid duplicating work.
> 
> Create a new bug and cc us, so we can talk about the path forward there.

OK, I will create a new bug.