Closed
Bug 1233599
Opened 9 years ago
Closed 9 years ago
Add build dependencies to appcompat-v7
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox44 fixed, firefox45 fixed, firefox46 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
Firefox 46
People
(Reporter: mcomella, Assigned: nalexander)
Details
Attachments
(1 file)
|
2.25 KB,
patch
|
mcomella
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This follow-up was backed out of bug 1220309 but I need it to compile to test for bug 1232777.
|
Reporter | |
Comment 1•9 years ago
|
||
Attachment #8699699 -
Flags: review+
|
|
Reporter | |
Comment 2•9 years ago
|
||
NI to land this once the tree opens.
Flags: needinfo?(michael.l.comella)
|
|
Reporter | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/595d8e0cb3edb582c4bcd7f834ef8542f51cff1b
Bug 1233599 - Add build dependencies to appcompat-v7. r=mcomella
|
|
Reporter | |
Updated•9 years ago
|
Flags: needinfo?(michael.l.comella)
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
|
|
Reporter | |
Comment 5•9 years ago
|
||
Nick, do you know which version this has to go into?
Flags: needinfo?(nalexander)
|
Assignee | |
Comment 6•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #5)
> Nick, do you know which version this has to go into?
I assume you mean how far should this be uplifted? It's needed on beta and aurora. I'll set the flags now.
Flags: needinfo?(nalexander)
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8699699 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: typo.
[User impact if declined]: none.
[Describe test coverage new/current, TreeHerder]: build-only, and it's fixed in central and hacked together on beta. When aurora uplifts, it will break, just like beta did.
[Risks and why]: very low -- if it builds, we're happy.
[String/UUID change made/needed]: none.
Attachment #8699699 -
Flags: approval-mozilla-beta?
Attachment #8699699 -
Flags: approval-mozilla-aurora?
Comment on attachment 8699699 [details] [diff] [review]
Patch
Makes sense, Beta44+, Aurora45+
Attachment #8699699 -
Flags: approval-mozilla-beta?
Attachment #8699699 -
Flags: approval-mozilla-beta+
Attachment #8699699 -
Flags: approval-mozilla-aurora?
Attachment #8699699 -
Flags: approval-mozilla-aurora+
status-firefox44:
--- → affected
status-firefox45:
--- → affected
|
||
Comment 9•9 years ago
|
||
| bugherder uplift | ||
I'm hitting conflicts trying to uplift this to beta. Can we get a rebased patch for 44?
Flags: needinfo?(nalexander)
Ping? We're down to two weeks left for beta 44.
|
|
Assignee | |
Comment 12•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/62bedad6519c
Sorry, Wes -- this was build only so I didn't prioritize it. Let's hope it's green :)
Flags: needinfo?(nalexander)
|
|
||
Comment 13•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #12)
> https://hg.mozilla.org/releases/mozilla-beta/rev/62bedad6519c
>
> Sorry, Wes -- this was build only so I didn't prioritize it. Let's hope
> it's green :)
setting flags :)
|
|
||
Comment 14•9 years ago
|
||
| bugherder uplift | ||
status-b2g-v2.5:
--- → fixed
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•