Closed Bug 1233599 Opened 7 years ago Closed 7 years ago

Add build dependencies to appcompat-v7

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 fixed, firefox45 fixed, firefox46 fixed, b2g-v2.5 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: mcomella, Assigned: nalexander)

Details

Attachments

(1 file)

This follow-up was backed out of bug 1220309 but I need it to compile to test for bug 1232777.
NI to land this once the tree opens.
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(michael.l.comella)
https://hg.mozilla.org/mozilla-central/rev/595d8e0cb3ed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Nick, do you know which version this has to go into?
Flags: needinfo?(nalexander)
(In reply to Michael Comella (:mcomella) from comment #5)
> Nick, do you know which version this has to go into?

I assume you mean how far should this be uplifted?  It's needed on beta and aurora.  I'll set the flags now.
Flags: needinfo?(nalexander)
Comment on attachment 8699699 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: typo.

[User impact if declined]: none.

[Describe test coverage new/current, TreeHerder]: build-only, and it's fixed in central and hacked together on beta.  When aurora uplifts, it will break, just like beta did.

[Risks and why]: very low -- if it builds, we're happy.

[String/UUID change made/needed]: none.
Attachment #8699699 - Flags: approval-mozilla-beta?
Attachment #8699699 - Flags: approval-mozilla-aurora?
Comment on attachment 8699699 [details] [diff] [review]
Patch

Makes sense, Beta44+, Aurora45+
Attachment #8699699 - Flags: approval-mozilla-beta?
Attachment #8699699 - Flags: approval-mozilla-beta+
Attachment #8699699 - Flags: approval-mozilla-aurora?
Attachment #8699699 - Flags: approval-mozilla-aurora+
I'm hitting conflicts trying to uplift this to beta. Can we get a rebased patch for 44?
Flags: needinfo?(nalexander)
Ping? We're down to two weeks left for beta 44.
https://hg.mozilla.org/releases/mozilla-beta/rev/62bedad6519c

Sorry, Wes -- this was build only so I didn't prioritize it.  Let's hope it's green :)
Flags: needinfo?(nalexander)
(In reply to Nick Alexander :nalexander from comment #12)
> https://hg.mozilla.org/releases/mozilla-beta/rev/62bedad6519c
> 
> Sorry, Wes -- this was build only so I didn't prioritize it.  Let's hope
> it's green :)

setting flags :)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.