Closed
Bug 1233621
Opened 9 years ago
Closed 8 years ago
Add validation for rule fields which accept operators
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), defect)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: ashish.sareen95, Mentored)
References
Details
Attachments
(1 obsolete file)
Bug 1021022 added support for operators on version and buildID, eg version >= 42.0. We don't have any validation at rule submission time though, which would be useful to avoid footguns. There's a WIP at bug 1021022 comment #8 and feedback in the following comment.
|
||
Updated•8 years ago
|
Mentor: bhearsum
|
|
||
Updated•8 years ago
|
Assignee: nobody → ashish.sareen95
I've separated the version and builId validators. I've kept the buildID validator in the operator_validator method. I wanted some feedback on this before I update the PR.
Attachment #8741924 -
Flags: review?(bhearsum)
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8741924 [details] [diff] [review] mypatch.patch We're looking at this in https://github.com/mozilla/balrog/pull/70 now.
Attachment #8741924 -
Attachment is obsolete: true
Attachment #8741924 -
Flags: review?(bhearsum)
|
||
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/e40daa4268a824fc548f2c9b2e4f32b74e5e2392 Bug 1233621 - Add validation for rule fields which accept operators (#70). r=bhearsum
|
|
||
Comment 4•8 years ago
|
||
This made it to production today. Thank you for pushing this along Ashish!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•