Closed
Bug 1233632
Opened 9 years ago
Closed 8 years ago
Moz2Dify GetBlurAndSpreadRadius()
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
5.59 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Another small, easy Moz2Dification step.
Assignee | ||
Comment 1•9 years ago
|
||
The CurrentMatrix()-to-GetTransform() change in GetBlurAndSpreadRadius() is valid because the operations performed on the resulting |transform| only consult the _11, _12, _21 and _22 members; not the _31 and _32 members (which are different in gfxContext vs. DrawTarget).
Attachment #8699826 -
Flags: review?(dholbert)
Updated•9 years ago
|
Attachment #8699826 -
Flags: review?(dholbert) → review+
Comment 2•8 years ago
|
||
Waiting for something for checking in?
Updated•8 years ago
|
Flags: needinfo?(n.nethercote)
Assignee | ||
Comment 3•8 years ago
|
||
I've been on PTO. I will land it today.
Flags: needinfo?(n.nethercote)
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee768634ba9caf777ee91bf94b1d2c23fdeaaf16 Bug 1233632 - Moz2Dify GetBlurAndSpreadRadius(). r=dholbert.
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ee768634ba9c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee | ||
Comment 6•8 years ago
|
||
Looks like either this bug or bug 1233631 (I don't know which because I landed them together) caused this Talos improvement: > (Improvement) Mozilla-Inbound-Non-PGO - CanvasMark - WINNT 6.1 (ix) (e10s) - 3.01% > (Improvement) Mozilla-Inbound-Non-PGO - CanvasMark - WINNT 6.1 (ix) - 3.49% > (Improvement) Mozilla-Inbound-Non-PGO - CanvasMark - WINNT 5.1 (ix) - 3.27%
You need to log in
before you can comment on or make changes to this bug.
Description
•