Closed Bug 1233650 Opened 4 years ago Closed 4 years ago

Remove DecodedStream::AddOutput/RemoveOutput

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

which doesn't fit into the interface of MediaSink.
Assignee: nobody → jwwang
Comment on attachment 8701021 [details]
MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc.

https://reviewboard.mozilla.org/r/28859/#review25803

You can preserve history here by using "hg copy" to create the new file.
Comment on attachment 8701022 [details]
MozReview Request: Bug 1233650. Part 2 - make OutputStreamManager ref-counted so it can be shared between MDSM and DecodedStream. r=roc.

https://reviewboard.mozilla.org/r/28861/#review25805
Comment on attachment 8701023 [details]
MozReview Request: Bug 1233650. Part 3 - move creation of OutputStreamManager from DecodedStream to MDSM. r=roc.

https://reviewboard.mozilla.org/r/28863/#review25807
Comment on attachment 8701024 [details]
MozReview Request: Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc.

https://reviewboard.mozilla.org/r/28865/#review25809
Attachment #8701024 - Flags: review?(roc) → review+
Attachment #8701021 - Flags: review?(roc)
Comment on attachment 8701021 [details]
MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28859/diff/1-2/
Comment on attachment 8701022 [details]
MozReview Request: Bug 1233650. Part 2 - make OutputStreamManager ref-counted so it can be shared between MDSM and DecodedStream. r=roc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28861/diff/1-2/
Comment on attachment 8701023 [details]
MozReview Request: Bug 1233650. Part 3 - move creation of OutputStreamManager from DecodedStream to MDSM. r=roc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28863/diff/1-2/
Comment on attachment 8701024 [details]
MozReview Request: Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28865/diff/1-2/
Comment on attachment 8701021 [details]
MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc.

https://reviewboard.mozilla.org/r/28859/#review25841
Thanks for the review!
Blocks: 1197110
Duplicate of this bug: 1197111
You need to log in before you can comment on or make changes to this bug.