Closed
Bug 1233650
Opened 9 years ago
Closed 8 years ago
Remove DecodedStream::AddOutput/RemoveOutput
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
which doesn't fit into the interface of MediaSink.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jwwang
|
|
Assignee | |
Comment 1•9 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f83088f2ccf0
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28859/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28859/
Attachment #8701021 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28861/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28861/
Attachment #8701022 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28863/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28863/
Attachment #8701023 -
Flags: review?(roc)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28865/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/28865/
Attachment #8701024 -
Flags: review?(roc)
Attachment #8701021 -
Flags: review?(roc)
Comment on attachment 8701021 [details] MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc. https://reviewboard.mozilla.org/r/28859/#review25803 You can preserve history here by using "hg copy" to create the new file.
Attachment #8701022 -
Flags: review?(roc) → review+
Comment on attachment 8701022 [details] MozReview Request: Bug 1233650. Part 2 - make OutputStreamManager ref-counted so it can be shared between MDSM and DecodedStream. r=roc. https://reviewboard.mozilla.org/r/28861/#review25805
Attachment #8701023 -
Flags: review?(roc) → review+
Comment on attachment 8701023 [details] MozReview Request: Bug 1233650. Part 3 - move creation of OutputStreamManager from DecodedStream to MDSM. r=roc. https://reviewboard.mozilla.org/r/28863/#review25807
Comment on attachment 8701024 [details] MozReview Request: Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc. https://reviewboard.mozilla.org/r/28865/#review25809
Attachment #8701024 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8701021 -
Flags: review?(roc)
|
|
Assignee | |
Comment 10•9 years ago
|
||
Comment on attachment 8701021 [details] MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28859/diff/1-2/
|
|
Assignee | |
Comment 11•9 years ago
|
||
Comment on attachment 8701022 [details] MozReview Request: Bug 1233650. Part 2 - make OutputStreamManager ref-counted so it can be shared between MDSM and DecodedStream. r=roc. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28861/diff/1-2/
|
|
Assignee | |
Comment 12•9 years ago
|
||
Comment on attachment 8701023 [details] MozReview Request: Bug 1233650. Part 3 - move creation of OutputStreamManager from DecodedStream to MDSM. r=roc. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28863/diff/1-2/
|
|
Assignee | |
Comment 13•9 years ago
|
||
Comment on attachment 8701024 [details] MozReview Request: Bug 1233650. Part 4 - remove unused functions from DecodedStream. r=roc. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28865/diff/1-2/
Attachment #8701021 -
Flags: review?(roc) → review+
Comment on attachment 8701021 [details] MozReview Request: Bug 1233650. Part 1 - extract OutputStreamManager to its own file. r=roc. https://reviewboard.mozilla.org/r/28859/#review25841
|
|
Assignee | |
Comment 15•8 years ago
|
||
Thanks for the review!
|
||
Comment 16•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f3fe94a2323 https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc77e0ec2c9 https://hg.mozilla.org/integration/mozilla-inbound/rev/3d3e1d9f36f5 https://hg.mozilla.org/integration/mozilla-inbound/rev/903769cc0aac
|
||
Comment 17•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f3fe94a2323 https://hg.mozilla.org/mozilla-central/rev/8cc77e0ec2c9 https://hg.mozilla.org/mozilla-central/rev/3d3e1d9f36f5 https://hg.mozilla.org/mozilla-central/rev/903769cc0aac
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•