remove Mutex typedef from gfx/2d

RESOLVED FIXED in Firefox 48

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: vlad, Assigned: nical)

Tracking

unspecified
mozilla48
Points:
---

Firefox Tracking Flags

(firefox48 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(1 attachment)

gfx/2d/JobScheduler_posix.h has:

typedef mozilla::gfx::CriticalSection Mutex;
typedef mozilla::gfx::CriticalSectionAutoEnter MutexAutoLock;

these should go away; they interfere unnecessarily with the much more globally used mozilla::Mutex in code that uses gfx or or is in the gfx namespace.

Updated

2 years ago
Whiteboard: gfx-noted
(Assignee)

Comment 1

2 years ago
Created attachment 8731751 [details] [diff] [review]
Remove the typedef

Oops, forgot about about this. Here's the patch.
Assignee: nobody → nical.bugzilla
Attachment #8731751 - Flags: review?(vladimir)
Comment on attachment 8731751 [details] [diff] [review]
Remove the typedef

This is super nitpicky, but I would keep mMutex as the member name.. mainly because a mutex is universal, whereas a CRITICAL_SECTION is somewhat of a win32-ism that Bas infec^W^Wthat was introduced into gfx/2d ;) But meh.
Attachment #8731751 - Flags: review?(vladimir) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/39f16ff40154

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/39f16ff40154
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.