Closed Bug 1233743 Opened 8 years ago Closed 8 years ago

remove Mutex typedef from gfx/2d

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: vlad, Assigned: nical)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

gfx/2d/JobScheduler_posix.h has:

typedef mozilla::gfx::CriticalSection Mutex;
typedef mozilla::gfx::CriticalSectionAutoEnter MutexAutoLock;

these should go away; they interfere unnecessarily with the much more globally used mozilla::Mutex in code that uses gfx or or is in the gfx namespace.
Whiteboard: gfx-noted
Oops, forgot about about this. Here's the patch.
Assignee: nobody → nical.bugzilla
Attachment #8731751 - Flags: review?(vladimir)
Comment on attachment 8731751 [details] [diff] [review]
Remove the typedef

This is super nitpicky, but I would keep mMutex as the member name.. mainly because a mutex is universal, whereas a CRITICAL_SECTION is somewhat of a win32-ism that Bas infec^W^Wthat was introduced into gfx/2d ;) But meh.
Attachment #8731751 - Flags: review?(vladimir) → review+
https://hg.mozilla.org/mozilla-central/rev/39f16ff40154
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.