https://devcenter.heroku.com/articles/cedar-14-migration I tried doing this, but was running into npm package issues.
I wish I had filed a more detailed description with the errors I was seeing, but I believe that this is only needed for deploying code. We can land code, but we just can't deploy a new package apparently.
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Comment on attachment 8707403 [details] [review] [autolander] edmorley:fix-heroku-build > mozilla:master The failed build log is here: https://dashboard.heroku.com/apps/autolander/activity/builds/55be32af-49ba-46e3-b7d6-8b36dbf634f8 The last successful build is here: https://dashboard.heroku.com/apps/autolander/activity/builds/d807d78c-0c98-4661-85a3-8bd4a0e23785 My first thought that perhaps the nodejs version has changed, however both logs report it as v0.11.14, which makes sense, since it's pinned in package.json (as recommended): https://github.com/mozilla/autolander/blob/a6a277ccf080c72d03efe66ed8f5a886f07972c3/package.json#L19 Since the stack has changed, the nodejs buildpack invalidates the node_modules cache, which means the other possible cause is that one of the subdependencies has been updated, since there is no npm shrinkwrap file in the repo. The first error message in the log is: """ make: Entering directory `/tmp/build_3b887ae9f63b7e4ce76870d7ee99b62f/mozilla-autolander-a6a277c/node_modules/taskcluster-client/node_modules/sockjs-client-node/node_modules/jsdom/node_modules/contextify/build' CXX(target) Release/obj.target/contextify/src/contextify.o In file included from ../src/contextify.cc:3:0: ../node_modules/nan/nan.h: In function ‘void Nan::SetCounterFunction(v8::CounterLookupCallback)’: ../node_modules/nan/nan.h:459:32: error: ‘class v8::Isolate’ has no member named ‘SetCounterFunction’ """ Which seems to be due to an update of the NaN module now not supporting this old (v0.11.x) version of nodejs: https://github.com/bnoordhuis/node-iconv/issues/127#issuecomment-130333596 This PR updates Heroku to a newer version of nodejs.
Attachment #8707403 - Flags: review?(kevin+bugzilla)
Comment on attachment 8707403 [details] [review] [autolander] edmorley:fix-heroku-build > mozilla:master This is great, thanks for taking this on!
Attachment #8707403 - Flags: review?(kevin+bugzilla) → review+
Pull request has landed in master: https://github.com/mozilla/autolander/commit/e978107600db56ca666f07ce0433ac3795f45fb7
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
I've enabled travis for the mozilla/autolander repo, and I've also added Ed Morley explicitly as a contributor to the repo - I hope that's ok Ed :)
Comment on attachment 8707483 [details] [review] [autolander] mozilla:bug_1233745_cedar_upgrade_test > mozilla:master I've upgraded to cedar-14 with the following command: `heroku stack:set cedar-14 -a autolander`. I've also deployed the master branch of autolander to heroku. This was a test pull request attachment to quickly sanity check prod, it seems all is well now. Thanks!
Attachment #8707483 - Attachment is obsolete: true
That's great, thank you :-)
You need to log in before you can comment on or make changes to this bug.