1233770 - Unable to interact with dropdown menu on mydealz.de

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Taylor [:miketaylr]]

Originally reported at https://github.com/webcompat/web-bugs/issues/1973, this appears to be a regression.

I tried bisecting, but got a weird final result: 

23:31.46 LOG: MainThread Bisector INFO Last good revision: 5dbceb9638a01828296241661ff3c644d894f118
23:31.46 LOG: MainThread Bisector INFO First bad revision: c921afa9fc3e164ab52dc4564349a92e16663317
23:31.46 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=5dbceb9638a01828296241661ff3c644d894f118&tochange=c921afa9fc3e164ab52dc4564349a92e16663317


STR:

1. visit mydealz.de
2. click on any of the dropdown arrow menus (top blue bar, or green bar)

Expected: dropdown menu is displayed
Actual: page navigation

This one is kinda tricky, it seems like the top blue menu bar hits more easily than the green ones. 

Narrowed down to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cd345a81ac341641c52fdeb744ab2b80eccc0aa9&tochange=cc473fe5dc512c450634506f68cbacfb40a06a23 (and gave up) which have two bugs w/ touch related stuff:

Bug 1174532 & Bug 1222234

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Mike did the review for 1222234.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I think this is bug 1222234 comment 10 and the continued discussion – we increased the link target area and it makes it harder to click links on the page. bug 1233272 may be another manifestation to this. The two bugs (this one and bug 1233272) will like get duped to bug 1222234 once we figure out the best way to handle it.

Comment 3

[:Margaret Leibovic]

Yeah, sounds like a regression from bug 1222234. We could back that out to fix this.

Comment 5

[Dominique Vincent [:domivinc]]

Michael, I made some tests without the code changes from bug 1222234, it doesn't fix totally the issues:
- For the arrows in the green area, it works correctly (I get the vertical menu).
- For the arrow in the blue area, it still doesn't work. To get the vertical menu for this blue arrow, I have to deactivate totally the "closest link" behavior (change the pref ui.mouse.radius.enabled to false).

So this issue is more visible with bug 1222234, but it won't be totally fixed without the code changes from bug 1222234.

Both issues (blue and green arrows) are not visible in version 44.0b2.
Both issues are visible in 45.0a2.

The blue arrow issue is strange: there are 2 links in the blue area (the home logo and the vertical menu) but it's another link below the blue area that is triggered (the ad area). 

Kats, do you know if there is another change in the "closest link" code explaining the blue arrow issue?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

So the PositionedEventTargeting.* files are identical in aurora and beta. The difference in behaviour must be coming from somewhere else. I don't know of any other changes that would have affected this between 44 and 45.

Comment 7

[Dominique Vincent [:domivinc]]

Michael, my previous comment was based on the change of the preference values in about:config ; it doesn't fix the issue. 
I built a new apk with the back out of the code from bug 1222234, and now the issue is fixed.
I'm going to investigate why the changes in about:config are not correctly applied and give the same results.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Backed out bug 1222234 – this should be fixed (see bug 1222234 comment 34).