Fira - Add Condensed Style

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: patryk, Assigned: ivanovpavel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Can we please add the condensed style to the OS with the same weights as Fira Sans?
Created attachment 8700426 [details] [review]
patch for master
Attachment #8700426 - Flags: review?(mwu)

Updated

2 years ago
Attachment #8700426 - Flags: review?(mwu) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/moztt/commit/e58218ed5175132d9645882688a653140a9de94c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Hi, did a revert of this push, seems this caused a bustage on b2g-inbound on all builds like https://treeherder.mozilla.org/logviewer.html#?job_id=3604742&repo=b2g-inbound
Flags: needinfo?(pivanov)
Ahh ... sorry about that ... there was a typo in

FiraSansCondensed-ExtraboldItalic.otf
should be: 
FiraSansCondensed-ExtraBoldItalic.otf
bold with capital "B"

I create a new PR https://github.com/mozilla-b2g/moztt/pull/81

Carsten: I will merge it now. Sorry again for this bug
Flags: needinfo?(pivanov)
Landed to master:
https://github.com/mozilla-b2g/moztt/commit/7617333eacd5038470d1e26dcdba45f7d610caad
I had to revert this again for more build failures:
https://github.com/mozilla-b2g/moztt/commit/5645fe28c66f0be19975d604cb33b6fdae558348

https://treeherder.mozilla.org/logviewer.html#?job_id=3608986&repo=b2g-inbound#L4672
Flags: needinfo?(pivanov)

Updated

2 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
File name was wrong. Now should be OK
Flags: needinfo?(pivanov)
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.