1233807 - Find solution for push-extender to allow employees not using their moco email address

Status: RESOLVED INVALID

(Testing :: General, defect)

Description

[Armen [:armenzg]]

If we can get to use OKTA soon, perhaps we should look into revisiting using the new auth features which TC now has to determine commit access.
Perhaps we need to handle this better in pulse_actions.
We should also output a link to the revision a resulset_id refers to.

Dec 18 05:34:20 pulse-actions app/worker2.1: root	 INFO:	 New jobs requested by [e-mail] on repo_name try with resultset_id: 82310 
Dec 18 05:34:21 pulse-actions app/worker2.1: INFO:	 New jobs requested by [e-mail] on repo_name try with resultset_id: 82310 
Dec 18 05:34:22 pulse-actions app/worker2.1: Traceback (most recent call last): 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 75, in run_pulse 
Dec 18 05:34:22 pulse-actions app/worker2.1:     pulse.listen() 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 151, in listen 
Dec 18 05:34:22 pulse-actions app/worker2.1:     self._drain_events_loop() 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/mozillapulse/consumers.py", line 198, in _drain_events_loop 
Dec 18 05:34:22 pulse-actions app/worker2.1:     self.connection.drain_events(timeout=self.timeout) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/connection.py", line 275, in drain_events 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return self.transport.drain_events(self.connection, **kwargs) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/transport/pyamqp.py", line 95, in drain_events 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return connection.drain_events(**kwargs) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/amqp/connection.py", line 325, in drain_events 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return amqp_method(channel, args, content) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/amqp/channel.py", line 1909, in _basic_deliver 
Dec 18 05:34:22 pulse-actions app/worker2.1:     fun(msg) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 596, in _receive_callback 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return on_m(message) if on_m else self.receive(decoded, message) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/.heroku/python/lib/python2.7/site-packages/kombu/messaging.py", line 563, in receive 
Dec 18 05:34:22 pulse-actions app/worker2.1:     [callback(body, message) for callback in callbacks] 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "pulse_actions/worker.py", line 66, in handler_with_dry_run 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return event_handler(data, message, dry_run) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/route_functions.py", line 15, in route 
Dec 18 05:34:22 pulse-actions app/worker2.1:     treeherder_runnable.on_runnable_job_prod_event(data, message, dry_run) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/treeherder_runnable.py", line 20, in on_runnable_job_prod_event 
Dec 18 05:34:22 pulse-actions app/worker2.1:     return on_runnable_job_event(data, message, dry_run, stage=False) 
Dec 18 05:34:22 pulse-actions app/worker2.1:   File "/app/pulse_actions/handlers/treeherder_runnable.py", line 66, in on_runnable_job_event 
Dec 18 05:34:22 pulse-actions app/worker2.1:     requester) 
Dec 18 05:34:22 pulse-actions app/worker2.1: Exception: Requester [e-mail] is not allowed to trigger jobs.

Comment 1

[Armen [:armenzg]]

What do you think we should do in here?

Comment 2

[Syd Polk :sydpolk]

Attachment: MozReview Request: Bug 1233807 - Update requirements in external-media-tests for CPOW errors. r?maja_zf

Review commit: https://reviewboard.mozilla.org/r/34245/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34245/

Comment 3

[Syd Polk :sydpolk]

Comment on attachment 8717629 [details]
MozReview Request: Bug 1233807 - Update requirements in external-media-tests for CPOW errors. r?maja_zf

Wrong bug

Comment 4

[Armen [:armenzg]]

I currently whitelist users.
At the moment, it is not worth investing in here.