Closed Bug 1233827 Opened 4 years ago Closed 4 years ago

Event dialog: change context menu for attendee and attachment boxes

Categories

(Calendar :: Dialogs, defect)

Lightning 4.7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Details

Attachments

(1 file, 1 obsolete file)

Follow up to bug 1229148:

- in the attendee box, for an area with no attendees, there should be a context menu displaying all menu items not related to a single attendeee (currently, there's no context menu in this case)

- in the attachment dialog for an area with no attachment list entry, the context menu should only display items not related to a specific list item
This patch modifies the context menus for attachment and attendee tabpanels in the event dialog.

If no attendees are available, there's now a context menu to open the attendee dialog. If there are attendees, context menu shows items related to a specific attendee only, when the click was on that attendee. Otherwise those items are not displayed. Left double click an an attendee opens the attendee dialog.

If there are no attachments, the context menu only shows the item to add a webpage. The same applies, if there are attachments, but the click was not targeted to those but the spare area of the box. The context menu for attachments stays the same with all options. Left double clicking on an attachment opens the link in the browser.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Attachment #8700387 - Flags: review?(philipp)
Summary: Event dialog: change context menu for attendee and attachement boxes → Event dialog: change context menu for attendee and attachment boxes
This also needs to go to aurora.
Attachment #8700387 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8700387 [details] [diff] [review]
AdaptEventDialogContextMenus-V1.diff

Review of attachment 8700387 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/base/content/dialogs/calendar-event-dialog.js
@@ +3639,5 @@
> +            if (!isAttendeeUndecided(aAttendee)) {
> +                responsiveAttendees++;
> +            }
> +        };
> +        window.attendees.forEach(countUndecided);

I know you are copying this, but to improve it, can you turn around the condition here and then use window.attendees.some(isAttendeeUndecided) ?

You don't have to do this for the aurora patch.
Attachment #8700387 - Flags: review?(philipp)
Attachment #8700387 - Flags: review+
Attachment #8700387 - Flags: approval-calendar-aurora?(philipp)
Attachment #8700387 - Flags: approval-calendar-aurora+
Updated patch according to the above comment. We should use the same patch for central and aurora.

Additionally, I modified the block to show/hide the individual context menu items as it turned out that in case of hitting the padding space between the attendee those items weren't disabled.

(re-requesting aurora approval as I cannot set this myself)
Attachment #8700387 - Attachment is obsolete: true
Attachment #8702891 - Flags: review+
Attachment #8702891 - Flags: approval-calendar-aurora?(philipp)
Attachment #8702891 - Flags: approval-calendar-aurora?(philipp) → approval-calendar-aurora+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/586f1324ab64a4dc8644abfc7b323f7e35726a83
Bug 1233827 - Event dialog: change context menu for attendee and attachment boxes;r=philipp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Keywords: checkin-needed
Whiteboard: [checkin-needed comm-aurora]
Whiteboard: [checkin-needed comm-aurora]
You need to log in before you can comment on or make changes to this bug.