1233847 - [Settings] The APN Settings button under Cellular and Data menu does not work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Michael Bryant (uber)]

On Flame if you have a SIM card in your phone and go to select "APN settings" under the Cellular and Data menu nothing happens. Additionally the back and operator buttons stop working.

STR:
1) Have a Flame with the correct build and a SIM Card
2) Launch the settings application, select "Cellular and Data"
3) Select your SIM card and then "APN Settings"

Expected Result:
4) The Phone takes you to the APN Settings page

Actual Result:
4) The "APN settings" button is highlighted in blue but nothing happens. Clicking on "Operator" or the "<" button don't do anything either. You can exit to the home screen and kill the application.


Device information:
Build ID               20151218152433
Gaia Revision          d069027f9af6f835ef869f1f01b52339e5a3f423
Gaia Date              2015-12-18 08:50:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c5cb194cc9cb56d742fb3a7a826f0080b0404edc
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151218.144545
Firmware Date          Fri Dec 18 14:45:55 UTC 2015
Bootloader             L1TC000118D0

Comment 1

[No-Jun Park [:njpark]]

adding keyword for regression check.  we know that on Build ID 20151216120920, it was fine.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

I can't repro this on today's Flame nightly, but I did repro it on the reported build. I'm guessing this is very recent, within half a day.

QA-wanted for a branch check anyway and also check on latest Aries.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Aries central is also affected.

Device: Aries 2.6
BuildID: 20151218153622
Gaia: d069027f9af6f835ef869f1f01b52339e5a3f423
Gecko: c5cb194cc9cb56d742fb3a7a826f0080b0404edc
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 46.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

-----------

Flame 2.5 is unaffected.

Device: Flame 2.5
BuildID: 20151218180935
Gaia: eeed1451e0e48b63abe3199e4d6906adc2a762d2
Gecko: 766600655dfb1b67c380b9da4f4b19acb505a858
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

-----

I'll be working on getting the window. Also took out Flame keyword on title since it's not exclusive to Flame.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working
Device: Flame 2.6
BuildID: 20151217224655
Gaia: 3d5b7c537d8d8e2eb9731d6a39e44bc8606bcfbc
Gecko: 63254aa6dfabeced552c9401cf9fb3cfa9b7add4
Version: 46.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

First Broken
Device: Flame 2.6
BuildID: 20151217230056
Gaia: 272a18a1457db9ee975fd7c3e0eff333f391265b
Gecko: 4b36d090fb5d368c7204a9cb44fe6b460be52224
Version: 46.0a1 (2.6) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

Last Working Gaia First Broken Gecko - no repro
Gaia: 3d5b7c537d8d8e2eb9731d6a39e44bc8606bcfbc
Gecko: 4b36d090fb5d368c7204a9cb44fe6b460be52224

Last Working Gecko First Broken Gaia - repro
Gaia: 272a18a1457db9ee975fd7c3e0eff333f391265b
Gecko: 63254aa6dfabeced552c9401cf9fb3cfa9b7add4

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/3d5b7c537d8d8e2eb9731d6a39e44bc8606bcfbc...272a18a1457db9ee975fd7c3e0eff333f391265b

Caused by changes made in Bug 1232589.

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fred can you please take a look at this?  Seems to be cause of the changes for bug 1232589.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1233847 > mozilla-b2g:master

Comment 9

[[e-mail]]

Thanks for catching that!

The apn_settings panel is not loaded correctly due to lack of the global object ApnHelper, which is removed in previous patch.

Comment 10

[[e-mail]]

r=me, merged https://github.com/mozilla-b2g/gaia/commit/69195defbbb725032c317136aa0e7a704b94bb4a

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame master and Aries KK master by the STR in comment 0.

Actual results:  The APN Settings item under Cellular and Data menu works good.
See attachment: verified_Flame_master.3gp
Reproduce rate: 0/10


Device: Flame master_512mb (Pass)
Build ID               20151221150211
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151221.182728
Firmware Date          Mon Dec 21 18:27:42 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151221204910
Gaia Revision          14aefb2519becfa32f31bcc3c9c995693421f19c
Gaia Date              2015-12-21 06:34:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8c9825377d0d8115e9fed64fd3700b1e54700dbe
Gecko Version          46.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151221.200242
Firmware Date          Mon Dec 21 20:02:51 UTC 2015
Bootloader             s1

Comment 12

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_master.3gp