Closed Bug 1233864 Opened 8 years ago Closed 8 years ago

Intermittent browser_site_loading_background_test.js | Browser - Site loading background validate loading background color

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aryx, Assigned: u520299)

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe][MJS])

Attachments

(1 file)

[gaia] tilmankamp:u1233864 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mikehenrty
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #1118637 +++

https://treeherder.mozilla.org/logviewer.html#?job_id=18792053&repo=mozilla-inbound

20:45:02     INFO -  TEST-START | apps/system/test/marionette/browser_site_loading_background_test.js | Browser - Site loading background validate loading background color

20:45:02     INFO -  TEST-UNEXPECTED-FAIL | apps/system/test/marionette/browser_site_loading_background_test.js | Browser - Site loading background validate loading background color
20:45:02     INFO -  Error: timeout exceeded!
20:45:02     INFO -      at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:760:16)
20:45:02     INFO -      at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
20:45:02     INFO -      at Object.MarionetteHelper.waitForElement (node_modules/marionette-helper/index.js:142:12)
20:45:02     INFO -      at Object.appChrome (apps/system/test/marionette/lib/system.js:149:31)
20:45:02     INFO -      at apps/system/test/marionette/browser_site_loading_background_test.js:80:20
20:45:02     INFO -      at modifiedTest (node_modules/marionette-client/lib/marionette/client.js:722:22)
20:45:02     INFO -      at Object.Client.waitForSync (node_modules/marionette-client/lib/marionette/client.js:754:9)
20:45:02     INFO -      at Object.Client.waitFor (node_modules/marionette-client/lib/marionette/client.js:726:60)
20:45:02     INFO -      at Context.<anonymous> (apps/system/test/marionette/browser_site_loading_background_test.js:79:12)
20:45:02     INFO -      at Test.MarionetteTest.run (node_modules/marionette-js-runner/lib/ui.js:25:31)
20:45:02     INFO -      at node_modules/marionette-js-runner/node_modules/promise/lib/core.js:33:15
20:45:02     INFO -      at flush (node_modules/marionette-js-runner/node_modules/promise/node_modules/asap/asap.js:27:13)
20:45:02     INFO -  TEST-END | apps/system/test/marionette/browser_site_loading_background_test.js | Browser - Site loading background validate loading background color took 23039 ms
20:45:02     INFO -  Exit code 1
Whiteboard: [systemsfe]
This was happening a lot when we disabled the retry logic in bug 1222215, so I'm disabling this to make way for landing that.

disabled in master: https://github.com/mozilla-b2g/gaia/commit/fb7fd564afb93f4ee39cf388d3b528448a20460b
Whiteboard: [systemsfe] → [systemsfe][MJS]
To see examples of this failure on treeherder, look at Gij 16 with the retry logic disabled here:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5e7f982dc23e

disabled in master: https://github.com/mozilla-b2g/gaia/commit/d4be6321eabdb28d824a0d28e5efef828c1afece
Julien, this looks like an important test, can you help this get some eyes on it?
Flags: needinfo?(felash)
Michael, wrong bug maybe ?
Flags: needinfo?(felash) → needinfo?(mhenretty)
Yeah, sorry I think I meant bug 1234689. Looks like Oleg is already on it. Thanks!
Flags: needinfo?(mhenretty)
Assignee: nobody → tilman
Attachment #8712137 - Flags: review?(mhenretty)
Please attach a treeherder link with 40/40 green retry runs.
Flags: needinfo?(tilman)
Just retried. Fails now already after a handful of runs. Will try to get 40/40 by further improvements. Sorry for the noise.
Status: NEW → ASSIGNED
Flags: needinfo?(tilman)
Comment on attachment 8712137 [details] [review]
[gaia] tilmankamp:u1233864 > mozilla-b2g:master

Go ahead an re-flag me when you're ready.
Attachment #8712137 - Flags: review?(mhenretty)
Comment on attachment 8712137 [details] [review]
[gaia] tilmankamp:u1233864 > mozilla-b2g:master

Simplified the test by using helpers; now also waiting for color values to appear. Darkened darkpage.html.

50/50 green test runs:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c78ff36f30d6c483ecec1b70df71665742b143a9
Attachment #8712137 - Flags: review?(mhenretty)
Comment on attachment 8712137 [details] [review]
[gaia] tilmankamp:u1233864 > mozilla-b2g:master

Big r+. Everything must wait!
Attachment #8712137 - Flags: review?(mhenretty) → review+
Merged into master:
https://github.com/tilmankamp/gaia/commit/d1a058ba5d472eedcec6044bc771d5a959d46108
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.