1233894 - Remove deprecated-sync-thenables library

Status: RESOLVED DUPLICATE of bug 1233891

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Once all usages of deprecated-sync-thenables are gone, we can remove it entirely.

Comment 1

[Manish [:manishkk]]

Remove these with the file also?
https://searchfox.org/mozilla-central/search?q=deprecated-sync-thenables&case=false&regexp=false&path=

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Gonna throw this ni to Alex as well.

Comment 3

[Alexandre Poirot [:ochameau]]

Yes. But be careful to run all Devtools tests on try, breakage and intermittent failure are expected.
As its name says, these promises resolve synchronously and some is this code was known to depend on this behavior.
So removing them should involve understanding why and try to mitigate the dependency on synchronous code.

If there is any failure, we may try to remove the usages from tests first and only from debugger-client or thread-client.
It is not clear if all the leftover usages are relevant.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Fixed in bug 1233891.