Closed
Bug 1233932
Opened 10 years ago
Closed 10 years ago
improve error reporting for b2g_bumper stamp failures
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hwine, Assigned: hwine)
References
Details
(Whiteboard: [b2g_bumper])
Attachments
(2 files)
1.26 KB,
patch
|
jlund
:
review+
hwine
:
checked-in+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
jlund
:
review+
hwine
:
checked-in+
|
Details | Diff | Splinter Review |
I spent 1/2 the time finding the config with problems for bug 1233351 - we can do better.
b2g_bumper/files/run_b2g_bumper.sh
Sigh. Too quick to enter.
Two issues:
1) runner script doesn't say which branch failed. That's in run_b2g_bumper.sh
2) log file just shows stack trace:
213 20:50:19 FATAL - Uncaught exception: Traceback (most recent call last):
214 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1693, in run
215 20:50:19 FATAL - self.run_action(action)
216 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1635, in run_action
217 20:50:19 FATAL - self._possibly_run_method(method_name, error_if_missing=True)
218 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/mozharness/base/script.py", line 1576, in _possibly_run_method
219 20:50:19 FATAL - return getattr(self, method_name)()
220 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 595, in push_loop
221 20:50:19 FATAL - self.massage_manifests()
222 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 508, in massage_manifests
223 20:50:19 FATAL - self.map_remotes(manifest)
224 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 146, in map_remotes
225 20:50:19 FATAL - repo_manifest.rewrite_remotes(manifest, mapping_func)
226 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/mozharness/mozilla/repo_manifest.py", line 83, in rewrite_remotes
227 20:50:19 FATAL - m = mapping_func(r)
228 20:50:19 FATAL - File "/builds/b2g_bumper/mozharness/scripts/b2g_bumper.py", line 144, in mapping_func
229 20:50:19 FATAL - self._remote_mappings[m.getAttribute('fetch')] = orig_url
230 20:50:19 FATAL - AttributeError: 'NoneType' object has no attribute 'getAttribute'
There's only one cause for that error - a remote can't be found in the
config. Let's make that more explicit.
Improve time to resolution by not discarding information about _which_ branch(es) are having problems.
Avoid the hard-to-decipher-late-on-a-Friday-night stack trace in comment 1, and give a clue as to where the problem is.
Attachment #8700276 -
Flags: review?(jlund)
Updated•10 years ago
|
Attachment #8700275 -
Flags: review?(jlund) → review+
Updated•10 years ago
|
Attachment #8700276 -
Flags: review?(jlund) → review+
I think these are safe to land by anyone, as any side effects should be quickly apparent.
However, ni myself to land after PTO just in case.
Flags: needinfo?(hwine)
https://hg.mozilla.org/build/mozharness/rev/6b6b2c30e0aea412972b0eed784198d6771e1b99
bug 1233932 - improve b2g_bumper error messages; r=jlund
https://hg.mozilla.org/build/puppet/rev/2ed902cd20a494ef275220b4e86c91e0a116c59a
bug 1233932 - improve b2g_bumper error messages; r=jlund
Comment on attachment 8700276 [details] [diff] [review]
b2g_bumper.patch
in production with
https://hg.mozilla.org/build/mozharness/rev/5792bcee8f5f
Attachment #8700276 -
Flags: checked-in+
Comment on attachment 8700275 [details] [diff] [review]
run.patch
In production with:
https://hg.mozilla.org/build/puppet/rev/ff7fe1d132ae
Flags: needinfo?(hwine)
Attachment #8700275 -
Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•