Show Tracking Protection /whatsnew page to users updating to 43.0.1

VERIFIED FIXED

Status

www.mozilla.org
Pages & Content
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: agibson, Assigned: agibson)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1923349])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8700291 [details]
pocket-whatsnew.png

For reasons unknown, someone decided to show a /whatnew page for users updating to Firefox 43.0.1. This wasn't communicated to anyone on our team, so there is no logic in place to show anything appropriate. It is currently falling back to the pocket template (see attachment).

We should probably be showing the Tracking Protection /whatsnew template, which was shown to users updating to 42.
(Assignee)

Updated

2 years ago
Assignee: nobody → agibson
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Whiteboard: [kb=1923349]
(Assignee)

Comment 1

2 years ago
Created attachment 8700292 [details] [review]
GitHub pull request

Comment 2

2 years ago
I noticed this too and I have no idea why 43.0.1 whatsnew was enabled when it wasn't enabled for 43.0. 

+1 to Alex that we should show the TP template and not a video+pocket.

Comment 3

2 years ago
Are we going to try to get this merged and pushed on Monday?

Comment 4

2 years ago
Erin/Liz: any idea why /whatsnew was enabled on 43.0.1 when it wasn't for 43.0? Can we check to see if it going to be enabled in 43.0.2 and newer?
Flags: needinfo?(lhenry)
Flags: needinfo?(elancaster)
(Assignee)

Comment 5

2 years ago
(In reply to Chris More [:cmore] from comment #3)
> Are we going to try to get this merged and pushed on Monday?

There's a PR open and it's a simple code change. No problems getting this pushed on Monday.

Comment 6

2 years ago
(In reply to Alex Gibson [:agibson] from comment #5)
> (In reply to Chris More [:cmore] from comment #3)
> > Are we going to try to get this merged and pushed on Monday?
> 
> There's a PR open and it's a simple code change. No problems getting this
> pushed on Monday.

Sounds good. Just more curious how /whatsnew/ got enabled just for this dot release. Have a good weekend!
I don't know why this shows a whatsnew page, so far as I know, there were no plans for one. 
Sylvestre, rail, jordan, what happened here?
Flags: needinfo?(sledru)
Flags: needinfo?(rail)
Flags: needinfo?(lhenry)
Flags: needinfo?(jlund)
Fixing this before Monday would be better, so that we don't keep showing this to millions of users as they update. Alex, what would it take to fix it? If it's simple, can someone fix it as soon as possible please?
Flags: needinfo?(agibson)
(Assignee)

Comment 9

2 years ago
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Fixing this before Monday would be better, so that we don't keep showing
> this to millions of users as they update. Alex, what would it take to fix
> it? If it's simple, can someone fix it as soon as possible please?

I'll see if I can get someone to review/merge over the weekend. Depends who is available but will keep the bug updated.
Flags: needinfo?(agibson)
Thank you Alex, who are you asking? Please let me know. 
From my point of view we need to fix this immediately.
Flags: needinfo?(dougt)
(Assignee)

Comment 11

2 years ago
I have pinged reviewers in the pull request linked in Comment 1.

Comment 12

2 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/6d447e8e42574886c14f43d24fecfedbb9408665
[fix bug 1233947] Show Tracking Protection /whatsnew page to users updating to 43.0.1

https://github.com/mozilla/bedrock/commit/72492e44218e4da8e10af8038a207dd9791668e1
Merge pull request #3680 from alexgibson/bug-1233947-whatsnew-page-43-0-1

[fix bug 1233947] Show Tracking Protection /whatsnew page to users updating to 43.0.1

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 13

2 years ago
Change has been merged to master, now we just need to find someone who can push.
(Assignee)

Comment 14

2 years ago
I contacted jgmize in #www on IRC, and he's able to push this to prod later today.
(Assignee)

Comment 15

2 years ago
Verified fixed on production: https://www.mozilla.org/en-US/firefox/43.0.1/whatsnew/
Status: RESOLVED → VERIFIED
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #7)
> I don't know why this shows a whatsnew page, so far as I know, there were no
> plans for one. 
> Sylvestre, rail, jordan, what happened here?

This is a fallout of bug 1234001. Sorry about that.
Flags: needinfo?(rail)
This has been fixed. Clearing the ni
Flags: needinfo?(sledru)
Flags: needinfo?(jlund)
Flags: needinfo?(elancaster)
Flags: needinfo?(dougt)

Comment 18

2 years ago
Thanks everyone! Back to hopefully enjoying your weekend.

Comment 19

2 years ago
just to follow up on recording another observed side effect of this that was discovered.

 content featuring hello that might have been shown to some international users for the few days leading up to Dec. 19 since pocket was limited to only a few locales. (de, es-Es, ja and ru)

https://www.mozilla.org/ar/firefox/41.0/whatsnew/
https://www.mozilla.org/af/firefox/41.0/whatsnew/
https://www.mozilla.org/da/firefox/41.0/whatsnew/
...

as opposed to
https://www.mozilla.org/en-US/firefox/41.0/whatsnew/ (pocket featured after the video)
https://www.mozilla.org/de/firefox/41.0/whatsnew/ (pocket featured after the video)
https://www.mozilla.org/ru/firefox/41.0/whatsnew/ (pocket featured directly)

and comment from mark banner:

given the profile of the activity increase for Hello users this seemed to be a result of a general increase in users, rather than other types of activity.

The what's new page was shown to 43.0.1 users from around about the 18th - 19th (according to release-driver emails), and this fits exactly with the increased usage we saw on Hello.

We hadn't realised initially that for some locales the what's new page was showing Hello rather than Pocket, hence we didn't make the association sooner.
You need to log in before you can comment on or make changes to this bug.