1234033 - --with-system-bz2 fails to build with Clang

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Jan Beich]

mfbt/Compiler.h doesn't define MOZ_IS_GCC for Clang which makes config/gcc_hidden.h hide globals from libbz2.so. Before bug 836078 the code used #if (__GNUC__ >= 4) which worked fine for Clang pretending to be GCC 4.2.1.

updater.o: In function `PatchFile::LoadSourceFile(__sFILE*)':
toolkit/mozapps/update/updater/updater.cpp:(.text+0x1349): undefined reference to `BZ2_crc32Table'
/usr/bin/ld: updater.o: relocation R_X86_64_PC32 against `BZ2_crc32Table' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value

Comment 1

[Jan Beich]

Attachment: MozReview Request: Bug 1234033 - Unbreak build --with-system-bz2 using Clang. r?dvander

Review commit: https://reviewboard.mozilla.org/r/28707/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28707/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8700401 [details]
MozReview Request: Bug 1234033 - Unbreak build --with-system-bz2 using Clang. r?dvander

https://reviewboard.mozilla.org/r/28707/#review25899

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/61a36f055e0b

Comment 4

[Jan Beich]

Comment on attachment 8700401 [details]
MozReview Request: Bug 1234033 - Unbreak build --with-system-bz2 using Clang. r?dvander

Less downstream patches for ESR45.

Approval Request Comment
[Feature/regressing bug #]: bug 836078 regression
[User impact if declined]: Broken build --with-system-bz2 on some Clang platforms unless --disable-updater is also passed
[Describe test coverage new/current, TreeHerder]: Try build via reviewboard, landed in m-i, soon m-c
[Risks and why]: Broken build
[String/UUID change made/needed]: None

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/61a36f055e0b

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/804e88d73ce2