Closed Bug 1234047 Opened 8 years ago Closed 8 years ago

Intermittent crash test_peerConnection_removeVideoTrack.html,test_peerConnection_removeThenAddVideoTrackNoBundle.html | application crashed [@ mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer *,unsigned int)]

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: aryx, Assigned: mattwoodrow)

References

Details

(Keywords: crash, intermittent-failure, Whiteboard: [gfx-noted])

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=18816155&repo=mozilla-inbound

09:19:40     INFO -  47326 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_removeVideoTrack.html | RTP flowing for track {b62685ad-6932-4c10-b6e1-5e072b34de16}
09:19:40     INFO -  47327 INFO Element pcRemote_local1_video saw 'timeupdate', currentTime=1.1319727891156464s, readyState=4
09:19:40     INFO -  47328 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_removeVideoTrack.html | Media flowing for element: pcRemote_local1_video
09:19:40     INFO -  47329 INFO Element pcRemote_remote2_video saw 'timeupdate', currentTime=1.0303854875283447s, readyState=4
09:19:40  WARNING -  TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_removeVideoTrack.html | application terminated with exit code 1
09:19:40     INFO -  runtests.py | Application ran for: 0:03:27.032000
09:19:40     INFO -  zombiecheck | Reading PID log: c:\users\cltbld\appdata\local\temp\tmpqbid9wpidlog
09:19:54     INFO -  mozcrash Saved minidump as C:\slave\test\build\blobber_upload_dir\baae8470-e4c7-418b-ac30-5231855d18f5.dmp
09:19:54     INFO -  mozcrash Saved app info as C:\slave\test\build\blobber_upload_dir\baae8470-e4c7-418b-ac30-5231855d18f5.extra
09:19:54  WARNING -  PROCESS-CRASH | dom/media/tests/mochitest/test_peerConnection_removeVideoTrack.html | application crashed [@ mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer *,unsigned int)]
09:19:54     INFO -  Crash dump filename: c:\users\cltbld\appdata\local\temp\tmpnmacmk.mozrunner\minidumps\baae8470-e4c7-418b-ac30-5231855d18f5.dmp
09:19:54     INFO -  Operating system: Windows NT
09:19:54     INFO -                    6.1.7601 Service Pack 1
09:19:54     INFO -  CPU: x86
09:19:54     INFO -       GenuineIntel family 6 model 30 stepping 5
09:19:54     INFO -       8 CPUs
09:19:54     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
09:19:54     INFO -  Crash address: 0x5e5d8147
09:19:54     INFO -  Process uptime: 194 seconds
09:19:54     INFO -  Thread 36 (crashed)
09:19:54     INFO -   0  xul.dll!mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer *,unsigned int) [ImageClient.cpp:2b22358166d9 : 162 + 0x26]
09:19:54     INFO -      eip = 0x5e5d8147   esp = 0x1548f6e8   ebp = 0x1548fa00   ebx = 0x1548fa0c
09:19:54     INFO -      esi = 0x000000a2   edi = 0x19332ee0   eax = 0x6107ce3c   ecx = 0x69eb0ad9
09:19:54     INFO -      edx = 0x00335e39   efl = 0x00000206
09:19:54     INFO -      Found by: given as instruction pointer in context
09:19:54     INFO -   1  mozglue.dll!arena_run_reg_dalloc [jemalloc.c:2b22358166d9 : 3435 + 0x13]
09:19:54     INFO -      eip = 0x713a69b4   esp = 0x1548f6f8   ebp = 0x1548fa00
09:19:54     INFO -      Found by: stack scanning
09:19:54     INFO -   2  xul.dll!mozilla::layers::UpdateImageClientNow [ImageBridgeChild.cpp:2b22358166d9 : 474 + 0xb]
09:19:54     INFO -      eip = 0x5e61ee00   esp = 0x1548fa08   ebp = 0x1548fa28
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   3  xul.dll!RunnableFunction<void (*)(mozilla::layers::ImageClient *,RefPtr<mozilla::layers::ImageContainer> &&),mozilla::Tuple<mozilla::layers::ImageClient *,RefPtr<mozilla::layers::ImageContainer> > >::Run() [task.h:2b22358166d9 : 350 + 0x9]
09:19:54     INFO -      eip = 0x5e61add3   esp = 0x1548fa30   ebp = 0x1548fa54
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   4  xul.dll!MessageLoop::RunTask(Task *) [message_loop.cc:2b22358166d9 : 364 + 0xe]
09:19:54     INFO -      eip = 0x5ded8827   esp = 0x1548fa3c   ebp = 0x1548fa54
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   5  xul.dll!MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const &) [message_loop.cc:2b22358166d9 : 372 + 0x7]
09:19:54     INFO -      eip = 0x5ded3c49   esp = 0x1548fa5c   ebp = 0x1548fa60
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   6  xul.dll!MessageLoop::DoWork() [message_loop.cc:2b22358166d9 : 459 + 0x5]
09:19:54     INFO -      eip = 0x5ded44a3   esp = 0x1548fa68   ebp = 0x1548fa90
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   7  xul.dll!base::MessagePumpDefault::Run(base::MessagePump::Delegate *) [message_pump_default.cc:2b22358166d9 : 34 + 0x7]
09:19:54     INFO -      eip = 0x5ded86f5   esp = 0x1548fa98   ebp = 0x1548fac8
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   8  xul.dll!MessageLoop::RunInternal() [message_loop.cc:2b22358166d9 : 234 + 0xf]
09:19:54     INFO -      eip = 0x5ded87e3   esp = 0x1548fad0   ebp = 0x1548fae8
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -   9  xul.dll!MessageLoop::RunHandler() [message_loop.cc:2b22358166d9 : 227 + 0x5]
09:19:54     INFO -      eip = 0x5ded879b   esp = 0x1548faf0   ebp = 0x1548fb1c
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  10  xul.dll!MessageLoop::Run() [message_loop.cc:2b22358166d9 : 201 + 0x7]
09:19:54     INFO -      eip = 0x5ded8514   esp = 0x1548fb24   ebp = 0x1548fb3c
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  11  xul.dll!base::Thread::ThreadMain() [thread.cc:2b22358166d9 : 172 + 0xb]
09:19:54     INFO -      eip = 0x5dee8fe5   esp = 0x1548fb44   ebp = 0x1548fc30
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  12  xul.dll!`anonymous namespace'::ThreadFunc(void *) [platform_thread_win.cc:2b22358166d9 : 26 + 0x8]
09:19:54     INFO -      eip = 0x5dec61a9   esp = 0x1548fc38   ebp = 0x1548fc38
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  13  kernel32.dll!BaseThreadInitThunk + 0x12
09:19:54     INFO -      eip = 0x75fd3c45   esp = 0x1548fc40   ebp = 0x1548fc44
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  14  ntdll.dll!__RtlUserThreadStart + 0x27
09:19:54     INFO -      eip = 0x77b337f5   esp = 0x1548fc4c   ebp = 0x1548fc84
09:19:54     INFO -      Found by: call frame info
09:19:54     INFO -  15  ntdll.dll!_RtlUserThreadStart + 0x1b
09:19:54     INFO -      eip = 0x77b337c8   esp = 0x1548fc8c   ebp = 0x1548fc9c
09:19:54     INFO -      Found by: call frame info
This is on the border between media and gfx, maybe Matt has an idea.
Flags: needinfo?(matt.woodrow)
Whiteboard: [gfx-noted]
Summary: Intermittent crash test_peerConnection_removeVideoTrack.html | application crashed [@ mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer *,unsigned int)] → Intermittent crash test_peerConnection_removeVideoTrack.html,test_peerConnection_removeThenAddVideoTrackNoBundle.html | application crashed [@ mozilla::layers::ImageClientSingle::UpdateImage(mozilla::layers::ImageContainer *,unsigned int)]
We failing an assertion that ensures that if we get the same layers::Image twice, then we also get the same TextureClient.

It looks like IMFYCbCrImage doesn't enforce that.
Attached patch imf-imageSplinter Review
Assignee: nobody → matt.woodrow
Flags: needinfo?(matt.woodrow)
Attachment #8706185 - Flags: review?(bas)
Attachment #8706185 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/bc9f37187bbf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: