1234060 - Adjust the attendee box in Event dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Richard Marti (:Paenglab)]

This bug is to fix the new attendee tab in event dialog. Also to make the .item-attendees-cell on Windows like the attachment items.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: AttendeeFix.patch

I reverted the #event-grid-tabpanels to the native appearance because on OS X it looks really weird.

The empty boxes in the different tabs are now aligned.

The .item-attendees-cell on Windows looks now like the other tree/listbox elements. This is limited to only :hover and :focus because where is no other possibility, but this should be enough.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 8700410 [details] [diff] [review]
AttendeeFix.patch

Bug 1229148 is in aurora and it makes sense to use this bug also there.

Comment 3

[[:MakeMyDay]]

Attachment: tabpanels.png

Thank you for providing the patch to make it consistent with other tabpanel implementations.

r=me with comments below considered, although I don't like that white styling (also for the other occurences in TB; but that's just a matter of personal preference).

I've applied this on a Win7 installation and I have only two remarks:

- the tabpanel (as all other in TB) has a small white space right und top to the panel, which is looking odd - see the attached screenshot. Is this intended?

- the attachment listbox items don't get highlighted when hovering. I don't know how this is handled elsewhere, so maybe this intended. But in any case the hover effect should be consistent for attachments and attendees.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: AttendeeFix.patch

(In reply to MakeMyDay from comment #3)
> Created attachment 8700416 [details]
> tabpanels.png
> 
> Thank you for providing the patch to make it consistent with other tabpanel
> implementations.
> 
> r=me with comments below considered, although I don't like that white
> styling (also for the other occurences in TB; but that's just a matter of
> personal preference).
> 
> I've applied this on a Win7 installation and I have only two remarks:
> 
> - the tabpanel (as all other in TB) has a small white space right und top to
> the panel, which is looking odd - see the attached screenshot. Is this
> intended?

This comes not from TB, this comes from toolkit. To fix this it needs it needs a bug under toolkit filed. But I doubt it will be fixed with the planned deprecation of XUL. Especially when it's not used in FX.

> - the attachment listbox items don't get highlighted when hovering. I don't
> know how this is handled elsewhere, so maybe this intended. But in any case
> the hover effect should be consistent for attachments and attendees.

Good catch, I removed the :hover state.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/c80c08722de9c6dfbde15276ae531d2d4b7878f0
Bug 1234060 - Adjust the attendee box in Event dialog. r=MakeMyDay

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 2f6a5e35a314