Closed Bug 1234076 Opened 6 years ago Closed 6 years ago

Upgrade builder image to use tc-vcs 2.3.17

Categories

(Taskcluster Graveyard :: Docker Images, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: garndt, Assigned: garndt)

Details

Attachments

(1 file)

This version gives us artifact checking and some other nice things to prevent full cloning when things go wrong.
This patch not only upgrades tc-vcs, but also allows those builds to use the new in-tree docker image building.
Attachment #8701495 - Flags: review?(wcosta)
Comment on attachment 8701495 [details]
MozReview Request: Bug 1234076 - upgrade tc-vcs to 2.3.17 r=wcosta

https://reviewboard.mozilla.org/r/28977/#review25761

::: testing/docker/builder/Dockerfile:26
(Diff revision 1)
>  

Isn't necessary to update the VERSION file anymore? How inherited images will know the image has been upgrade, directory diff?
Attachment #8701495 - Flags: review?(wcosta)
Comment on attachment 8701495 [details]
MozReview Request: Bug 1234076 - upgrade tc-vcs to 2.3.17 r=wcosta

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28977/diff/1-2/
This latest change will remove the concept of a docker registry image complete for 'builder'.  All tasks using the 'builder' image will not use the in-tree docker image support.  VERSION file isn't necessary as the contents of the directory are hashed and compared to determine if the image should be rebuilt.
Comment on attachment 8701495 [details]
MozReview Request: Bug 1234076 - upgrade tc-vcs to 2.3.17 r=wcosta

https://reviewboard.mozilla.org/r/28977/#review25963
Attachment #8701495 - Flags: review?(wcosta) → review+
https://hg.mozilla.org/mozilla-central/rev/4ad0371b1a07
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Taskcluster → Taskcluster Graveyard
You need to log in before you can comment on or make changes to this bug.