optimization for nsWindowWatcher::OpenWindowJS

VERIFIED FIXED

Status

()

Core
Embedding: APIs
--
enhancement
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: timeless, Assigned: Adam Lock)

Tracking

Trunk
x86
FreeBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

16 years ago
 
(Reporter)

Comment 1

16 years ago
Created attachment 67787 [details] [diff] [review]
only check windowmodal if we aren't sure if the child should be modal
(Assignee)

Comment 2

16 years ago
Comment on attachment 67787 [details] [diff] [review]
only check windowmodal if we aren't sure if the child should be modal

r=adamlock
Attachment #67787 - Flags: review+
(Assignee)

Comment 3

16 years ago
timeless, do you want to get the sr and check this in?

Updated

16 years ago
QA Contact: mdunn → depstein

Comment 4

16 years ago
+    PRBool weAreModal = chromeFlags & nsIWebBrowserChrome::CHROME_MODAL;

This is a bad way to set a boolean. You could end up with non-low bits set in
the variable. You want
  (chromeFlags & nsIWebBrowserChrome::CHROME_MODAL) != 0
(Reporter)

Comment 5

16 years ago
Created attachment 74044 [details] [diff] [review]
same patch w/ ()!=0

i was tempted to use !!() but was concerned that the number of comments i'd get
if i did that would exceed the number of lines added/removed in the patch...
Attachment #67787 - Attachment is obsolete: true

Comment 6

16 years ago
Comment on attachment 74044 [details] [diff] [review]
same patch w/ ()!=0

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #74044 - Flags: approval+
(Reporter)

Comment 7

16 years ago
fixed
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 8

16 years ago
Timeless, seems like the wrong patch was checked in. It contains:  
  PRBool weAreModal = chromeFlags & nsIWebBrowserChrome::CHROME_MODAL;

Comment 9

16 years ago
reopening. you need to create another patch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 10

16 years ago
Ignore me. I see the later fixup checkin now ...
Status: REOPENED → RESOLVED
Last Resolved: 16 years ago16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
verified against 3/15/02 Mozilla debug build 0.9.9
mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.