123409 - optimization for nsWindowWatcher::OpenWindowJS

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[timeless]

Comment 1

[timeless]

Attachment: only check windowmodal if we aren't sure if the child should be modal

Comment 2

[Adam Lock]

Comment on attachment 67787 [details] [diff] [review]
only check windowmodal if we aren't sure if the child should be modal

r=adamlock

Comment 3

[Adam Lock]

timeless, do you want to get the sr and check this in?

Comment 4

[Simon Fraser [no longer active]]

+    PRBool weAreModal = chromeFlags & nsIWebBrowserChrome::CHROME_MODAL;

This is a bad way to set a boolean. You could end up with non-low bits set in
the variable. You want
  (chromeFlags & nsIWebBrowserChrome::CHROME_MODAL) != 0

Comment 5

[timeless]

Attachment: same patch w/ ()!=0

i was tempted to use !!() but was concerned that the number of comments i'd get
if i did that would exceed the number of lines added/removed in the patch...

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 74044 [details] [diff] [review]
same patch w/ ()!=0

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 7

[timeless]

fixed

Comment 8

[Jerome Lacoste]

Timeless, seems like the wrong patch was checked in. It contains:  
  PRBool weAreModal = chromeFlags & nsIWebBrowserChrome::CHROME_MODAL;

Comment 9

[Håkan Waara]

reopening. you need to create another patch

Comment 10

[Håkan Waara]

Ignore me. I see the later fixup checkin now ...

Comment 11

[David Epstein]

verified against 3/15/02 Mozilla debug build 0.9.9
mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp