Closed Bug 1234127 Opened 5 years ago Closed 5 years ago

Access to BluetoothAdapter.pairingReqs attribute causes the whole app crash

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
2.6 S4 - 1/1
Tracking Status
firefox46 --- fixed

People

(Reporter: yhong, Assigned: brsun)

References

Details

Attachments

(1 file)

No description provided.
Do you access from bluetooth app? Gekco prevents other apps from accessing it [1].

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/common/webapi/BluetoothAdapter.cpp#335
Flags: needinfo?(yhong)
Assignee: nobody → brsun
Status: NEW → ASSIGNED
Attachment #8701302 - Flags: review?(btian)
(In reply to Ben Tian [:btian] from comment #1)
> Do you access from bluetooth app? Gekco prevents other apps from accessing
> it [1].
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/common/webapi/
> BluetoothAdapter.cpp#335

The way Gecko prevents others apps from accessing is crashing currently. |BluetoothAdapter.pairingReqs| should be a nullable attribute instead.
See Also: → 1175389
(In reply to Bruce Sun [:brsun] from comment #3)
> 
> The way Gecko prevents others apps from accessing is crashing currently.
> |BluetoothAdapter.pairingReqs| should be a nullable attribute instead.

I also encountered this (bug 1175389 comment 9) during solving the emulator bug,
it's annoying, thanks to Bruce's patch!
Comment on attachment 8701302 [details] [diff] [review]
bug1234127_bluetooth_adapter_null_pairingreqs.patch

Review of attachment 8701302 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Please also request DOM peer review.
Attachment #8701302 - Flags: review?(btian) → review+
Flags: needinfo?(yhong)
Summary: Access the `pairingReqs` attribute of the `BluetoothAdapter` cause the whole app crash → Access to BluetoothAdapter.pairingReqs attribute causes the whole app crash
Comment on attachment 8701302 [details] [diff] [review]
bug1234127_bluetooth_adapter_null_pairingreqs.patch

Hi Blake,

Some WebAPI would be changed due to this patch. Would you please help to review it? Any comments would be appreciated.
Attachment #8701302 - Flags: review+ → review?(mrbkap)
See Also: → 1234974
Attachment #8701302 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/e61c31bf49237a13b7ccf0b7f59e06112009bb38
Bug 1234127: Change |BluetoothAdapter.pairingReqs| as a nullable object; r=btian, r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/e61c31bf4923
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S4 - 1/1
You need to log in before you can comment on or make changes to this bug.