1234153 - Hide block list feature correctly behind Nightly flag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Family Friendly Browsing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

I think the way I hide the block list feature behind a Nightly flag is wrong:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#39-41

If this is not a Nightly build the BLOCK_LIST feature will not be added to the configuration with value "false". This means we will return "true" from isAllowed() (Unknown feature fallback):
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#81-83

Instead we could always add this feature to the configuration (with false) and in Nightly builds add it to "hiddenRestrictions": Only in Nightly builds this restriction will be configurable. For all other builds it's disabled (false) and can't be changed.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1234153 - Hide block list feature behind Nightly flag. r?margaret

Review commit: https://reviewboard.mozilla.org/r/30169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30169/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8705721 [details]
MozReview Request: Bug 1234153 - Hide block list feature behind Nightly flag. r?margaret

https://reviewboard.mozilla.org/r/30169/#review26879

Good catch.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/895e44661a5fcfd826d95c560990ecea25228b25
Bug 1234153 - Hide block list feature behind Nightly flag. r=margaret

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/895e44661a5f