Closed Bug 1234153 Opened 5 years ago Closed 5 years ago
Hide block list feature correctly behind Nightly flag
58 bytes, text/x-review-board-request
I think the way I hide the block list feature behind a Nightly flag is wrong: https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#39-41 If this is not a Nightly build the BLOCK_LIST feature will not be added to the configuration with value "false". This means we will return "true" from isAllowed() (Unknown feature fallback): https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#81-83 Instead we could always add this feature to the configuration (with false) and in Nightly builds add it to "hiddenRestrictions": Only in Nightly builds this restriction will be configurable. For all other builds it's disabled (false) and can't be changed.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Review commit: https://reviewboard.mozilla.org/r/30169/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/30169/
Attachment #8705721 - Flags: review?(margaret.leibovic)
Comment on attachment 8705721 [details] MozReview Request: Bug 1234153 - Hide block list feature behind Nightly flag. r?margaret https://reviewboard.mozilla.org/r/30169/#review26879 Good catch.
Attachment #8705721 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/integration/fx-team/rev/895e44661a5fcfd826d95c560990ecea25228b25 Bug 1234153 - Hide block list feature behind Nightly flag. r=margaret
You need to log in before you can comment on or make changes to this bug.