Closed Bug 1234153 Opened 5 years ago Closed 5 years ago

Hide block list feature correctly behind Nightly flag

Categories

(Firefox for Android Graveyard :: Family Friendly Browsing, defect)

All
Android
defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I think the way I hide the block list feature behind a Nightly flag is wrong:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#39-41

If this is not a Nightly build the BLOCK_LIST feature will not be added to the configuration with value "false". This means we will return "true" from isAllowed() (Unknown feature fallback):
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/restrictions/RestrictedProfileConfiguration.java#81-83

Instead we could always add this feature to the configuration (with false) and in Nightly builds add it to "hiddenRestrictions": Only in Nightly builds this restriction will be configurable. For all other builds it's disabled (false) and can't be changed.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Comment on attachment 8705721 [details]
MozReview Request: Bug 1234153 - Hide block list feature behind Nightly flag. r?margaret

https://reviewboard.mozilla.org/r/30169/#review26879

Good catch.
Attachment #8705721 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/895e44661a5f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.