Closed Bug 1234183 Opened 8 years ago Closed 8 years ago

Auto resize panel height

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RT, Assigned: dcritchley)

References

(
URL
)

Details

User Story

Acceptance criteria:
- Resize automatically the panel height if the list includes between 0 and 5 conversations
- Resize automatically the panel height when the user is in a room and opens the panel
- Set a fixed panel height if the panel includes 5 conversations or more

See attached documents for details on panel height based on number of conversations.

Attachments

(4 files)

Expanding Panel.png
94.49 KB, image/png
Details
Stop sharing tabs.png
42.67 KB, image/png
Details
Screenshots of new panel layout for review
469.04 KB, application/zip
sevaan
: ui-review+
Details
[loop] daveccrit:1234183-resizePanel > mozilla:master
40 bytes, text/x-github-pull-request
dmosedale
: review+
Details | Review 
      No description provided.
Attached image Expanding Panel.png — 

    
  
User Story: (updated)

    
  
Rank: 25
Priority: -- → P2

    
  
Blocks: 1209713

    
    

    
  
I would like to work on this item.

    
    

    
  

      
      
      
      

        Attached image
          
        Stop sharing tabs.png
        — 
      

    


  

    
  
User Story: (updated)

    
  
Assignee: nobody → dcritchley

    
  
Rank: 25 → 15

    
  
Priority: P2 → P1
Blocks: 1226607
Rank: 15 → 11

    
    

    
  
There is a min-height on the panel built into the browser. So we can't go any smaller than 214px without changing that parameter in the browser, which may have an impact other panels. My recommendation would be to stick with the 214px min height within our app for now and pursue having the panel min height changed for a release down the road, if we want to continue down that route. Should we proceed with working around the min-height?
Flags: needinfo?(sfranks)

    
    

    
  
Are we sure it's not simple to override? The downloads panel can be smaller than 214px (http://i.sevaan.com/0A1G1R1s033G)

If it's a real issue, I'm okay staying with 214px for the moment. It's still shorter than what the panel is now.
Flags: needinfo?(sfranks)

    
    

    
  
dcritch, where are you seeing the min-height being set by the browser?

    
    

    
  


  

        Attachment #8712223 -
        Flags: ui-review?(sfranks)

    
  

        Attachment #8712232 -
        Flags: review?(standard8)

        Attachment #8712232 -
        Flags: review?(edilee)

        Attachment #8712232 -
        Flags: review?(dmose)

        Attachment #8712223 -
        Flags: ui-review?(sfranks) → ui-review+

    
    

    
  
Comment on attachment 8712232 [details] [review]
[loop] daveccrit:1234183-resizePanel > mozilla:master

I'm going to skip review on this and leave it to Dan/Ed.

        Attachment #8712232 -
        Flags: review?(standard8)

    
    

    
  
Comment on attachment 8712232 [details] [review]
[loop] daveccrit:1234183-resizePanel > mozilla:master

Ed's already doing review for the pointer sharing; I'll pick this up tomorrow.

        Attachment #8712232 -
        Flags: review?(edilee)

    
    

    
  
Comment on attachment 8712232 [details] [review]
[loop] daveccrit:1234183-resizePanel > mozilla:master

Looks great; thanks for the ui-showcase SVG icon cleanup as well as the auto-resizing code.  r=dmose with the nits in the PR fixed if there are no mochitest changes required.  If mochitest changes are required, I'd like to have one more look.

        Attachment #8712232 -
        Flags: review?(dmose) → review+

    
    

    
  
One issue I noticed while testing, and this may or may not be a problem on master too: when testing on a profile for the first time with no rooms, I could create the first room, and it would work, but not appear in the panel.  All subsequent attempts (eg delete that room and create a new one) didn't have that problem.

It's not obvious to me that this would be caused by this patch, but please check before landing.

    
  
URL: https://github.com/mozilla/loop/commi...
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 1249577

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: