Closed Bug 1234199 Opened 5 years ago Closed 5 years ago

Android / iOS download links doesn’t work in synced tabs menu

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 46
Tracking Status
firefox45 --- verified
firefox46 --- verified

People

(Reporter: tchevalier, Assigned: markh)

References

Details

Attachments

(2 files)

When you haven’t started syncing other devices, the synced tabs menu offers you to download Firefox for Android and Firefox for iOS.

Clicking on the download links does nothing.

Tested on latest Dev edition 20151220004007 and Nightly 20151214122242
Blocks: 1201331
No longer blocks: 201331
oops - during that final review I ended with with |link.href = ...| instead of |link.setAttribute("href", ...);| - this 1-line patch fixes those links.

Drew, it seems Gijs is away - are you able to have a look at this?
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8700916 - Flags: review?(adw)
Attachment #8700916 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/d7a2a9cfdeb8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8700916 [details] [diff] [review]
0001-Bug-1234199-fix-mobile-promo-links-in-synced-tabs-me.patch

Approval Request Comment
[Feature/regressing bug #]:  1201331 
[User impact if declined]: Mobile promo links don't work
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: trivial 1 line fix
[String/UUID change made/needed]: None
Attachment #8700916 - Flags: approval-mozilla-aurora?
Comment on attachment 8700916 [details] [diff] [review]
0001-Bug-1234199-fix-mobile-promo-links-in-synced-tabs-me.patch

visual regression, taking it.
Attachment #8700916 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
I was able to reproduce this issue on Firefox 46.0a1 (2016-12-21) under Ubuntu 13.10 64-bit.
Verified fixed on Firefox 46.0a1 (2016-01-19) and Firefox 45.0a2 (2016-01-19/20) under Ubuntu 13.10 64-bit and Windows 10 64-bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.