1234199 - Android / iOS download links doesn’t work in synced tabs menu

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Théo Chevalier]

Attachment: Synced tabs menu on dev edition, Ubuntu 15.10

When you haven’t started syncing other devices, the synced tabs menu offers you to download Firefox for Android and Firefox for iOS.

Clicking on the download links does nothing.

Tested on latest Dev edition 20151220004007 and Nightly 20151214122242

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-1234199-fix-mobile-promo-links-in-synced-tabs-me.patch

oops - during that final review I ended with with |link.href = ...| instead of |link.setAttribute("href", ...);| - this 1-line patch fixes those links.

Drew, it seems Gijs is away - are you able to have a look at this?

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d7a2a9cfdeb8

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7a2a9cfdeb8

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8700916 [details] [diff] [review]
0001-Bug-1234199-fix-mobile-promo-links-in-synced-tabs-me.patch

Approval Request Comment
[Feature/regressing bug #]:  1201331 
[User impact if declined]: Mobile promo links don't work
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: trivial 1 line fix
[String/UUID change made/needed]: None

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8700916 [details] [diff] [review]
0001-Bug-1234199-fix-mobile-promo-links-in-synced-tabs-me.patch

visual regression, taking it.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a3d2912e28e

Comment 7

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 46.0a1 (2016-12-21) under Ubuntu 13.10 64-bit.
Verified fixed on Firefox 46.0a1 (2016-01-19) and Firefox 45.0a2 (2016-01-19/20) under Ubuntu 13.10 64-bit and Windows 10 64-bit.