123420 - ver.h should be winver.h in msdos\winsock\nsldap.rc

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[David Gardiner]

The file c-sdk\ldap\libraries\msdos\winsock\nsldap.rc #includes ver.h

According to http://support.microsoft.com/default.aspx?scid=kb;en-us;Q103719
though, ver.h is no longer to be used, and instead "winver.h" should be #included.

The KB article has proved prophetic, as with the release of Visual C++ 7.0 (as
part of Visual Studio .NET), ver.h no longer exists, and building Mozilla
doesn't work.

-dave

Comment 1

[David Gardiner]

Attachment: Patch .rc file to #include winver.h for _WIN32 builds

Comment 2

[Mark Smith [:mcs]]

What branch of the LDAP C SDK code are you building? Is it LDAPCSDK_40_BRANCH?

Comment 3

[David Gardiner]

yes.. as per what Mozilla pulls via client.mk

-dave

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

The 5.0 SDK branch appears to use ver.h as well.

Comment 5

[Mark Smith [:mcs]]

I suggest we just fix this on ldapcsdk_branch_50, assuming that will land soon
enough. The version numbers in the nsldap.rc file should be bumped to 5.0 also.

Dan, do you know if the new autoconf based builds use nsldap.rc? Our server-ish
C SDK builds do not as far as I know (perhaps they should).

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

The new autoconf stuff doesn't use it either.  So maybe nsldap.rc should just be
cvs removed on the 5.0 branch?

Comment 7

[Mark Smith [:mcs]]

I committed this fix along with some others on 2002-03-12 but forgot to mark
this bug as fixed. Done now.

Comment 8

[Frankie]

Spam for bug 129472