Closed Bug 1234216 Opened 4 years ago Closed 4 years ago

UI gets confusing if there are 2 compatible devices plugged in.

Categories

(Firefox OS Graveyard :: B2gInstaller, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: gerard-majax)

References

Details

Attachments

(3 files)

Attached image Screenshot
STR
1. Plug an aries
2. Plug a nexus 5

Expected results
Either: 
* a <ul> list that shows which device you want to flash
* or a label, warning the user that having 2 devices may have unwanted effects.

Results
The UI shows the Android serial of the nexus device. See screenshot. The console also reports:
> getprop: BAD_RESPONSE | about.js:766:7
As far as I can tell, ADB Helper itself is not really ready to handle multiple devices at once. Besides, I really don't have a good idea of how to handle this. There are a lot of questions to answer specifically because during the process we will have the device disappearing/reappearing.
Assignee: nobody → lissyx+mozillians
Right, it looks like there is a real issue hidden in fact. I have built a test case with two compatible devices but with different model (ro.product.model). This results in some mess up.
Attached file WIP PR
(In reply to Alexandre LISSY :gerard-majax from comment #4)
> Created attachment 8716489 [details]
> Capture du 2016-02-05 23-25-38.png

This is after plugging a Z3c while I already have a Flame plugged.
Comment on attachment 8716455 [details] [review]
WIP PR

This PR includes bug 1233029 but I will rebase when it lands.
Attachment #8716455 - Flags: review?(dale)
Comment on attachment 8716455 [details] [review]
WIP PR

Yeh I had a hard time thinking what to do with multiple devices, this looks sensible
Attachment #8716455 - Flags: review?(dale) → review+
https://github.com/mozilla-b2g/b2g-installer/commit/76da2796b6992a8c1cc6517c9ab520b85b893579
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.