Status

()

Firefox for Android
Family Friendly Browsing
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

35 Branch
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed, fennec45+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
In bug 1222381 we removed the custom theme for FFB, expecting that we would have a theme picker. But we don't. So let's add back the custom theme.
(Assignee)

Comment 1

2 years ago
Created attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/28819/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28819/
Attachment #8700870 - Flags: review?(s.kaspari)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28819/diff/1-2/
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

https://reviewboard.mozilla.org/r/28819/#review25659
Attachment #8700870 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/47cba7f5e4fe95a44465305241f745c0905ef02b
Bug 1234238 - Restore FFB theme. r=sebastian

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/47cba7f5e4fe
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
(Assignee)

Comment 6

2 years ago
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1222381.

[User impact if declined]: FFB theme will be missing in restricted profiles.

[Describe test coverage new/current, TreeHerder]: Tested manually.

[Risks and why]: Low-risk, only affects restricted profiles.

[String/UUID change made/needed]: None.
Attachment #8700870 - Flags: approval-mozilla-aurora?
status-firefox45: --- → affected
Attachment #8700870 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I'm hitting conflicts trying to uplift this to aurora. Can we get a rebased patch?
Flags: needinfo?(margaret.leibovic)
(Assignee)

Comment 8

2 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/0b0ad49b4317
status-firefox45: affected → fixed
Flags: needinfo?(margaret.leibovic)
You need to log in before you can comment on or make changes to this bug.