Closed Bug 1234238 Opened 4 years ago Closed 4 years ago

Restore FFB theme

Categories

(Firefox for Android Graveyard :: Family Friendly Browsing, defect)

35 Branch
defect
Not set

Tracking

(firefox45 fixed, firefox46 fixed, fennec45+)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
fennec 45+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

In bug 1222381 we removed the custom theme for FFB, expecting that we would have a theme picker. But we don't. So let's add back the custom theme.
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28819/diff/1-2/
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

https://reviewboard.mozilla.org/r/28819/#review25659
Attachment #8700870 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/mozilla-central/rev/47cba7f5e4fe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8700870 [details]
MozReview Request: Bug 1234238 - Restore FFB theme. r=sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1222381.

[User impact if declined]: FFB theme will be missing in restricted profiles.

[Describe test coverage new/current, TreeHerder]: Tested manually.

[Risks and why]: Low-risk, only affects restricted profiles.

[String/UUID change made/needed]: None.
Attachment #8700870 - Flags: approval-mozilla-aurora?
Attachment #8700870 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I'm hitting conflicts trying to uplift this to aurora. Can we get a rebased patch?
Flags: needinfo?(margaret.leibovic)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.