1234321 - foreignInstall add-ons should never update to preliminary signed versions

Status: RESOLVED WONTFIX

(Firefox :: Extension Compatibility, defect)

Description

[Mike Connor [:mconnor]]

Not sure if this is the right place for this, I flipped a coin.  Please move as needed.

If an add-on has been sideloaded, upgrading to a preliminary signed add-on version will result in a disabled add-on.  We simply shouldn't update those users.

Comment 1

[Andy McKay]

(In reply to Mike Connor [:mconnor] from comment #0)
> Not sure if this is the right place for this, I flipped a coin.  Please move
> as needed.
> 
> If an add-on has been sideloaded, upgrading to a preliminary signed add-on
> version will result in a disabled add-on.  We simply shouldn't update those
> users.

Can you clarify what a "preliminary signed add-on" is please? And why is it disabled?

Comment 2

[Tony Mechelynck [:tonymec]]

(In reply to Andy McKay [:andym] from comment #1)
> (In reply to Mike Connor [:mconnor] from comment #0)
> > Not sure if this is the right place for this, I flipped a coin.  Please move
> > as needed.
> > 
> > If an add-on has been sideloaded, upgrading to a preliminary signed add-on
> > version will result in a disabled add-on.  We simply shouldn't update those
> > users.
> 
> Can you clarify what a "preliminary signed add-on" is please? And why is it
> disabled?

He means a "preliminarily reviewed add-on", which has passed the AMO preliminary review, and got signed as a result, but has not undergone the comprehensive review. IIUC, sideloaded add-ons are disabled unless they have passed the comprehensive review; and as long as bug 1233459 isn't FIXED, the foreignInstall flag which marks an add-on as sideloaded cannot be cleared other than by uninstalling the add-on (updating isn't enough).

Comment 3

[Andy McKay]

(In reply to Tony Mechelynck [:tonymec] from comment #2)
> (In reply to Andy McKay [:andym] from comment #1)
> > (In reply to Mike Connor [:mconnor] from comment #0)
> > > Not sure if this is the right place for this, I flipped a coin.  Please move
> > > as needed.
> > > 
> > > If an add-on has been sideloaded, upgrading to a preliminary signed add-on
> > > version will result in a disabled add-on.  We simply shouldn't update those
> > > users.
> > 
> > Can you clarify what a "preliminary signed add-on" is please? And why is it
> > disabled?
> 
> He means a "preliminarily reviewed add-on", which has passed the AMO
> preliminary review, and got signed as a result, but has not undergone the
> comprehensive review. IIUC, sideloaded add-ons are disabled unless they have
> passed the comprehensive review; and as long as bug 1233459 isn't FIXED, the
> foreignInstall flag which marks an add-on as sideloaded cannot be cleared
> other than by uninstalling the add-on (updating isn't enough).

Right, thanks, I should have got that.

Comment 4

[Andy McKay]

If bug 1245956 happens, then this will be irrelevant.

Comment 5

[Andy McKay]

Based on bug 1245956, this can be closed.