1234322 - Strings for SendTo extension cannot be used in two targets

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The SendTo extension used to have two swift files that have localized strings:

 ClientPickerViewController.swift
 InstructionsViewController.swift

Doing a string export resulted in a section in the xliff named Extensions/SendTo/SendTo.strings


Since the Peek & Pop feature, the above two controllers are also used in the main app as part of the Send Tab Quick Action under the Peek.

Because of that these files are now part of both the Client and the SendTo targets.

That is good for code sharing, but from a strings perspective this won't work because localized strings can only be part of one bundle. So only one of the targets will get them.

It is also not possible for an extension to get the strings from its parent bundle (the app in which it is contained).

Not entirely sure what to do here.

One solution is that we manually copy the strings as part of the import-locales scripts. We do more whacky stuff there so this would be in line with that :-/

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

New script now knows about files that need to be duplicated:

Exporting firefox-ios-l10n/it/firefox-ios.xliff
  Writing Client/3DTouchActions.strings to Client/it.lproj/3DTouchActions.strings
  Writing Client/AuthenticationManager.strings to Client/it.lproj/AuthenticationManager.strings
  Writing Client/BookmarkPanel.strings to Client/it.lproj/BookmarkPanel.strings
  Writing Client/ClearHistoryConfirm.strings to Client/it.lproj/ClearHistoryConfirm.strings
  Writing Client/ClearPrivateData.strings to Client/it.lproj/ClearPrivateData.strings
  Writing Client/ErrorPages.strings to Client/it.lproj/ErrorPages.strings
  Writing Client/FindInPage.strings to Client/it.lproj/FindInPage.strings
  Writing Client/HistoryPanel.strings to Client/it.lproj/HistoryPanel.strings
  Writing Client/Info.plist to Client/it.lproj/InfoPlist.strings
  Writing Client/Intro.strings to Client/it.lproj/Intro.strings
  Writing Client/LightweightThemes.strings to Client/it.lproj/LightweightThemes.strings
  Writing Client/Localizable.strings to Client/it.lproj/Localizable.strings
  Writing Client/LoginManager.strings to Client/it.lproj/LoginManager.strings
  Writing Client/OnePasswordExtension.strings to Client/it.lproj/OnePasswordExtension.strings
  Writing Client/PrivateBrowsing.strings to Client/it.lproj/PrivateBrowsing.strings
  Writing Client/Search.strings to Client/it.lproj/Search.strings
  Writing Client/SendAnonymousUsageData.strings to Client/it.lproj/SendAnonymousUsageData.strings
  >>> Writing Client/SendTo.strings to Client/it.lproj/SendTo.strings
  >>> Writing Client/SendTo.strings to Extensions/SendTo/it.lproj/SendTo.strings
  Writing Extensions/SendTo/Info.plist to Extensions/SendTo/it.lproj/InfoPlist.strings
  Writing Extensions/ShareTo/ShareTo.strings to Extensions/ShareTo/it.lproj/ShareTo.strings
  Writing Extensions/ViewLater/Info.plist to Extensions/ViewLater/it.lproj/InfoPlist.strings
  Writing Client/Shared.strings to Client/it.lproj/Shared.strings
  Writing Client/Storage.strings to Client/it.lproj/Storage.strings

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios-build-tools/pull/12

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

https://github.com/mozilla/firefox-ios-build-tools/commit/2ac3413d1727cc31fcea2042550cd9c6d117c8b7

Comment 5

[Francesco Lodolo [:flod]]

Confirming that the feature is now localized in build 2.0 201601181633