1234337 - Deal with ramifications of GTK3/OS deprecation issues in TB45

Status: RESOLVED INVALID

(Thunderbird :: General, defect)

Description

[Kent James (:rkent)]

This bug follows issues hinted at in bug 1232847, specifically that we need a plan to manage the deprecation of GTK2 in builds.

Comment 1

[[e-mail] (:bhearsum)]

Should be easy enough to set-up watersheds like we did for Firefox. Are you ready for those?

Comment 2

[Kent James (:rkent)]

(In reply to Ben Hearsum (:bhearsum) from comment #1)
> Should be easy enough to set-up watersheds like we did for Firefox. Are you
> ready for those?

The issue deals with future builds, that is TB 45.0 and later. DO you need to actual builds to setup the watersheds, or can you do it ahead of time?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Kent James (:rkent) from comment #2)
> (In reply to Ben Hearsum (:bhearsum) from comment #1)
> > Should be easy enough to set-up watersheds like we did for Firefox. Are you
> > ready for those?
> 
> The issue deals with future builds, that is TB 45.0 and later. DO you need
> to actual builds to setup the watersheds, or can you do it ahead of time?

We need the watershed builds to be available. In the case of this GTK deprecation, we must watershed on a release that sends newer GTK version information (bug 1227023), but does not yet require GTK3. In Firefox's case we chose to watershed on the 44.0 RC for beta users, and 44.0 release (or latest available point release) for release users.

Comment 4

[Magnus Melin [:mkmelin]]

Right, so what is the plan for Firefox ESRs? Uplift bug 1227023 to ESR38 and watershed on the last 38.x release?
Because Thunderbird would have to do something like that, as we won't have any other release builds before 45.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Magnus Melin from comment #4)
> Right, so what is the plan for Firefox ESRs? Uplift bug 1227023 to ESR38 and
> watershed on the last 38.x release?
> Because Thunderbird would have to do something like that, as we won't have
> any other release builds before 45.

Ah, right. I forgot Thunderbird is ESR based.

Yes, I think that bug should be backported, otherwise users can't be updated to 45 safely. Come to think of it, we'll need it for Firefox as well.

Comment 6

[Kent James (:rkent)]

bhearsum requested uplift of bug 1227023, if that is accepted we'll have the esr38 piece, if not we'll need it on our own branch.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin from comment #4)
> Right, so what is the plan for Firefox ESRs? Uplift bug 1227023 to ESR38 and
> watershed on the last 38.x release?
> Because Thunderbird would have to do something like that, as we won't have
> any other release builds before 45.

But we will have beta 44 -> beta 45. We need watershed for that also, correct?  If so, can you do that for us?

And Thunderbird has what we need from bug 1227023?

Comment 8

[[e-mail] (:bhearsum)]

(In reply to Wayne Mery (:wsmwk, use Needinfo for questions) from comment #7)
> (In reply to Magnus Melin from comment #4)
> > Right, so what is the plan for Firefox ESRs? Uplift bug 1227023 to ESR38 and
> > watershed on the last 38.x release?
> > Because Thunderbird would have to do something like that, as we won't have
> > any other release builds before 45.
> 
> But we will have beta 44 -> beta 45. We need watershed for that also,
> correct?  If so, can you do that for us?

That's right. We need to set-up a watershed for Beta users that routes them through the latest 44.0 Beta. This can be done anytime after the 44.0 Beta has shipped, so we can probably do it anytime I think?

> And Thunderbird has what we need from bug 1227023?

I assume it does, because it's a toolkit patch, but I haven't double checked anything. Comparing the %OS_VERSION% part of the update URL with and without the patch should make it pretty clear.

Comment 9

[Magnus Melin [:mkmelin]]

So this bug is done now, right? 45 is already in beta (where gtk2 is used).

Comment 10

[Kent James (:rkent)]

(In reply to Magnus Melin from comment #9)
> So this bug is done now, right? 45 is already in beta (where gtk2 is used).

Yes, presumably the issue will come up again in the future, but we can do a new bug for that. There will be no gtk3 in TB45 so this bug is invalid.