1234406 - _PR_MD_INIT_THREAD does not set md.id field on Win32

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P2)

Description

[(No longer employed by Mozilla) Aaron Klotz]

When we create new threads with NSPR, the PRThread->md.id field is set, but we don't do it when attaching an existing thread to NSPR.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Comment 2

[Wan-Teh Chang]

Comment on attachment 8700847 [details] [diff] [review]
Patch

Review of attachment 8700847 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc. Thanks for the patch.

::: pr/src/md/windows/w95thred.c
@@ +71,5 @@
>                  GetCurrentProcess(),     /* Process of handle */
>                  &(thread->md.handle),    /* resulting handle */
>                  0L,                      /* access flags */
>                  FALSE,                   /* Inheritable */
>                  DUPLICATE_SAME_ACCESS);  /* Options */

Can you take the opportunity to check for DuplicateHandle() failure?

    if (!DuplicateHandle(
                ...)) {
        return PR_FAILURE;
    }

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch (r2)

Incorporated wtc's suggestion. Carrying forward r+.

Comment 4

[Wan-Teh Chang]

Attachment: Patch (r3) by Aaron Klotz

I edited the patch slightly and checked it in:
https://hg.mozilla.org/projects/nspr/rev/719eaabe5d83