Closed Bug 1234418 Opened 8 years ago Closed 8 years ago

"Assertion failure: !std::isnan(clusterStart) (Should have cluster start)" with text-emphasis-style

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jruderman, Assigned: xidorn)

References

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
Assertion failure: !std::isnan(clusterStart) (Should have cluster start), at gfx/thebes/gfxFont.cpp:1877
Attached file stack
Flags: needinfo?(quanxunzhen)
Hmmm, so a glyph run may start at a non-cluster-start character?
Flags: needinfo?(quanxunzhen)
Assignee: nobody → quanxunzhen
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #2)
> Hmmm, so a glyph run may start at a non-cluster-start character?

Yes, unfortunately -- it shouldn't happen in most "normal" content, but if there's a base character + combining mark from different scripts, for example (as in this case), and we end up rendering them from separate fonts, the mark will be at the beginning of a glyph run but it won't be a cluster start.
Attachment #8701274 - Flags: review?(jfkthame) → review+
Comment on attachment 8701274 [details]
MozReview Request: Bug 1234418 - Not trust glyph run starts from a cluster start character.

https://reviewboard.mozilla.org/r/28923/#review25885
https://hg.mozilla.org/integration/mozilla-inbound/rev/3242bee2d9568ac74d4c095dc7d2fac4798a02ca
Bug 1234418 - Not trust glyph run starts from a cluster start character. r=jfkthame
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4234af54e19616c56ab60a323ab9e845e2dd96c
Bug 1234418 - Not trust glyph run starts from a cluster start character. r=jfkthame
Flags: needinfo?(quanxunzhen)
https://hg.mozilla.org/mozilla-central/rev/f4234af54e19
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: