Closed
Bug 1234453
Opened 9 years ago
Closed 9 years ago
More complete save.1 UI Telemetry probes
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox44 fixed, firefox45 fixed, firefox46 fixed, b2g-v2.5 fixed)
RESOLVED
FIXED
Firefox 46
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
6.31 KB,
patch
|
Margaret
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
It occurred to me that we do not use specific "save.1" probes when saving a page to PDF, saving an image, saving a media file or printing a page. These all seem like "save" operations. They don't have an "unsave.1" counterpart though.
This patch adds "save.1" probes and adds comments for why "share.1" probes are not needed in the JS code.
Attachment #8700902 -
Flags: review?(margaret.leibovic)
Updated•9 years ago
|
Attachment #8700902 -
Flags: review?(margaret.leibovic) → review+
Updated•9 years ago
|
Assignee: nobody → mark.finkle
Comment 2•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1
Approval Request Comment
[Feature/regressing bug #]: We get a more complete picture of how people save content
[User impact if declined]: Less telemetry
[Describe test coverage new/current, TreeHerder]: Working on Nightly
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8700902 -
Flags: approval-mozilla-beta?
Attachment #8700902 -
Flags: approval-mozilla-aurora?
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1
Been on Nightly for a week, seems safe to uplift to Beta44, Aurora45.
Attachment #8700902 -
Flags: approval-mozilla-beta?
Attachment #8700902 -
Flags: approval-mozilla-beta+
Attachment #8700902 -
Flags: approval-mozilla-aurora?
Attachment #8700902 -
Flags: approval-mozilla-aurora+
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Comment 5•9 years ago
|
||
bugherder uplift |
Comment 6•9 years ago
|
||
bugherder uplift |
Comment 7•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•