Closed Bug 1234453 Opened 4 years ago Closed 4 years ago

More complete save.1 UI Telemetry probes

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

It occurred to me that we do not use specific "save.1" probes when saving a page to PDF, saving an image, saving a media file or printing a page. These all seem like "save" operations. They don't have an "unsave.1" counterpart though.

This patch adds "save.1" probes and adds comments for why "share.1" probes are not needed in the JS code.
Attachment #8700902 - Flags: review?(margaret.leibovic)
Attachment #8700902 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → mark.finkle
https://hg.mozilla.org/mozilla-central/rev/254e1fdb70f5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1

Approval Request Comment
[Feature/regressing bug #]: We get a more complete picture of how people save content
[User impact if declined]: Less telemetry
[Describe test coverage new/current, TreeHerder]: Working on Nightly
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8700902 - Flags: approval-mozilla-beta?
Attachment #8700902 - Flags: approval-mozilla-aurora?
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1

Been on Nightly for a week, seems safe to uplift to Beta44, Aurora45.
Attachment #8700902 - Flags: approval-mozilla-beta?
Attachment #8700902 - Flags: approval-mozilla-beta+
Attachment #8700902 - Flags: approval-mozilla-aurora?
Attachment #8700902 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.