More complete save.1 UI Telemetry probes

RESOLVED FIXED in Firefox 44, Firefox OS v2.5

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox44 fixed, firefox45 fixed, firefox46 fixed, b2g-v2.5 fixed)

Details

Attachments

(1 attachment)

Created attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1

It occurred to me that we do not use specific "save.1" probes when saving a page to PDF, saving an image, saving a media file or printing a page. These all seem like "save" operations. They don't have an "unsave.1" counterpart though.

This patch adds "save.1" probes and adds comments for why "share.1" probes are not needed in the JS code.
Attachment #8700902 - Flags: review?(margaret.leibovic)

Updated

2 years ago
Attachment #8700902 - Flags: review?(margaret.leibovic) → review+

Updated

2 years ago
Assignee: nobody → mark.finkle

Comment 2

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/254e1fdb70f5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1

Approval Request Comment
[Feature/regressing bug #]: We get a more complete picture of how people save content
[User impact if declined]: Less telemetry
[Describe test coverage new/current, TreeHerder]: Working on Nightly
[Risks and why]: Low
[String/UUID change made/needed]: None
Attachment #8700902 - Flags: approval-mozilla-beta?
Attachment #8700902 - Flags: approval-mozilla-aurora?

Comment 4

2 years ago
Comment on attachment 8700902 [details] [diff] [review]
more-save-telemetry v0.1

Been on Nightly for a week, seems safe to uplift to Beta44, Aurora45.
Attachment #8700902 - Flags: approval-mozilla-beta?
Attachment #8700902 - Flags: approval-mozilla-beta+
Attachment #8700902 - Flags: approval-mozilla-aurora?
Attachment #8700902 - Flags: approval-mozilla-aurora+

Updated

2 years ago
status-firefox44: --- → affected
status-firefox45: --- → affected

Comment 5

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/bdf4f899b2fc
status-firefox45: affected → fixed

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/4a5e057df43f
status-firefox44: affected → fixed

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4a5e057df43f
status-b2g-v2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.