If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove FHR's ExperimentsProvider

RESOLVED FIXED in Firefox 46

Status

Firefox Health Report
Client: Desktop
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

Trunk
Firefox 46
Points:
1

Firefox Tracking Flags

(firefox46 fixed)

Details

(Whiteboard: [measurement:client])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
This bug is about removing the ExperimentsProvider code and all of its uses [0] from the code.

[0] - https://dxr.mozilla.org/mozilla-central/search?q=ExperimentsProvider&redirect=false&case=true
(Assignee)

Updated

2 years ago
Blocks: 1230530
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
(Assignee)

Updated

2 years ago
Blocks: 1234491
(Assignee)

Updated

2 years ago
No longer blocks: 1234491
(Assignee)

Updated

2 years ago
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8701080 [details] [diff] [review]
bug1234490.patch
Attachment #8701080 - Flags: review?(gps)

Comment 2

2 years ago
Comment on attachment 8701080 [details] [diff] [review]
bug1234490.patch

Review of attachment 8701080 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/Experiments.jsm
@@ +213,5 @@
>    return deferred.promise;
>  }
>  
>  /**
> + * Strip a Date down to its UTC midnight.

Not sure why you moved this code. Meh.
Attachment #8701080 - Flags: review?(gps) → review+
(Assignee)

Comment 3

2 years ago
Created attachment 8701379 [details] [diff] [review]
bug1234490.patch

Whoops, my bad, moved it back.
Attachment #8701080 - Attachment is obsolete: true
Attachment #8701379 - Flags: review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/0935a2b6dad22b5b911a4d5946fd83b31e107740
Bug 1234490 - Remove the Experiments FHR provider. r=gps

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0935a2b6dad2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
You need to log in before you can comment on or make changes to this bug.