Closed Bug 1234490 Opened 8 years ago Closed 8 years ago

Remove FHR's ExperimentsProvider

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file, 1 obsolete file)

This bug is about removing the ExperimentsProvider code and all of its uses [0] from the code.

[0] - https://dxr.mozilla.org/mozilla-central/search?q=ExperimentsProvider&redirect=false&case=true
Blocks: 1230530
Points: --- → 1
Priority: -- → P1
Whiteboard: [measurement:client]
Blocks: 1234491
No longer blocks: 1234491
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attached patch bug1234490.patch (obsolete) — Splinter Review
Attachment #8701080 - Flags: review?(gps)
Comment on attachment 8701080 [details] [diff] [review]
bug1234490.patch

Review of attachment 8701080 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/experiments/Experiments.jsm
@@ +213,5 @@
>    return deferred.promise;
>  }
>  
>  /**
> + * Strip a Date down to its UTC midnight.

Not sure why you moved this code. Meh.
Attachment #8701080 - Flags: review?(gps) → review+
Attached patch bug1234490.patchSplinter Review
Whoops, my bad, moved it back.
Attachment #8701080 - Attachment is obsolete: true
Attachment #8701379 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/0935a2b6dad2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: