1234493 - Remove FHR's PasswordsMetricsProvider

Status: RESOLVED FIXED

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

This bug is about removing the PasswordsMetricsProvider and all of its uses [0] from the code.

[0] - https://dxr.mozilla.org/mozilla-central/search?q=PasswordsMetricsProvider+-path%3Aobj&redirect=false&case=true

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: bug1234493.patch

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8701118 [details] [diff] [review]
bug1234493.patch

Review of attachment 8701118 [details] [diff] [review]:
-----------------------------------------------------------------

IIRC, if the provider doesn't register (in this case, because it's been deleted!) nothing bad happens. If that's the case -- you start with an existing profile, upgrade to this code, and nothing bad happens -- then great.

I'm kinda disappointed that there's no test code to delete!

Comment 3

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=557ccd3eacae

Comment 4

[Alessio Placitelli [:Dexter]]

(In reply to Richard Newman [:rnewman] from comment #2)
> Comment on attachment 8701118 [details] [diff] [review]
> bug1234493.patch
> 
> Review of attachment 8701118 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> IIRC, if the provider doesn't register (in this case, because it's been
> deleted!) nothing bad happens. If that's the case -- you start with an
> existing profile, upgrade to this code, and nothing bad happens -- then
> great.

Thanks for reviewing. I tested locally on my old profile and nothing seems to break!

> I'm kinda disappointed that there's no test code to delete!

Seems to be the case for some other providers as well :(

Comment 5

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/fx-team/rev/0f9649cb1feee315d7cc11eee4f4756ec79cd18a
Bug 1234493 - Remove FHR's PasswordsMetricsProvider. r=rnewman

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0f9649cb1fee