Closed Bug 1234493 Opened 4 years ago Closed 4 years ago

Remove FHR's PasswordsMetricsProvider

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect, P1)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: Dexter, Assigned: Dexter)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

This bug is about removing the PasswordsMetricsProvider and all of its uses [0] from the code.

[0] - https://dxr.mozilla.org/mozilla-central/search?q=PasswordsMetricsProvider+-path%3Aobj&redirect=false&case=true
No longer depends on: 1234491
Blocks: 1234502
No longer blocks: 1234502
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Attached patch bug1234493.patchSplinter Review
Attachment #8701118 - Flags: review?(rnewman)
Comment on attachment 8701118 [details] [diff] [review]
bug1234493.patch

Review of attachment 8701118 [details] [diff] [review]:
-----------------------------------------------------------------

IIRC, if the provider doesn't register (in this case, because it's been deleted!) nothing bad happens. If that's the case -- you start with an existing profile, upgrade to this code, and nothing bad happens -- then great.

I'm kinda disappointed that there's no test code to delete!
Attachment #8701118 - Flags: review?(rnewman) → review+
(In reply to Richard Newman [:rnewman] from comment #2)
> Comment on attachment 8701118 [details] [diff] [review]
> bug1234493.patch
> 
> Review of attachment 8701118 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> IIRC, if the provider doesn't register (in this case, because it's been
> deleted!) nothing bad happens. If that's the case -- you start with an
> existing profile, upgrade to this code, and nothing bad happens -- then
> great.

Thanks for reviewing. I tested locally on my old profile and nothing seems to break!

> I'm kinda disappointed that there's no test code to delete!

Seems to be the case for some other providers as well :(
https://hg.mozilla.org/mozilla-central/rev/0f9649cb1fee
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.