Closed Bug 1234529 Opened 10 years ago Closed 8 years ago

crash in mozilla::media::DecodedAudioDataSink::DispatchTask

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Version:
43 Branch
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox43 --- affected
firefox44 --- affected
firefox45 --- affected
firefox46 --- fixed
firefox-esr45 --- affected

People

(Reporter: philipp, Unassigned)

References

Details

(Keywords: crash, regression)

Crash Data

This bug was filed from the Socorro interface and is report bp-6df3d627-0873-4a3d-8e50-72ca02151222. ============================================================= Crashing Thread (55) Frame Module Signature Source 0 xul.dll mozilla::media::DecodedAudioDataSink::DispatchTask(already_AddRefed<nsIRunnable>&&) dom/media/mediasink/DecodedAudioDataSink.cpp 1 xul.dll mozilla::media::DecodedAudioDataSink::SetVolume(double) dom/media/mediasink/DecodedAudioDataSink.cpp 2 xul.dll mozilla::media::AudioSinkWrapper::SetPlaybackParams(mozilla::media::MediaSink::PlaybackParams const&) dom/media/mediasink/AudioSinkWrapper.cpp 3 xul.dll mozilla::media::AudioSinkWrapper::Start(__int64, mozilla::MediaInfo const&) dom/media/mediasink/AudioSinkWrapper.cpp 4 xul.dll mozilla::MediaDecoderStateMachine::StartMediaSink() dom/media/MediaDecoderStateMachine.cpp 5 xul.dll mozilla::MediaDecoderStateMachine::MaybeStartPlayback() dom/media/MediaDecoderStateMachine.cpp 6 xul.dll mozilla::MediaDecoderStateMachine::RunStateMachine() dom/media/MediaDecoderStateMachine.cpp 7 nss3.dll PR_Assert nsprpub/pr/src/io/prlog.c 8 xul.dll nsRunnableMethodImpl<void ( mozilla::WatchManager<mozilla::MediaDecoder>::PerCallbackWatcher::*)(void), 1>::Run() xpcom/glue/nsThreadUtils.h 9 nss3.dll PR_ExitMonitor nsprpub/pr/src/threads/prmon.c 10 nss3.dll nss3.dll@0x357f 11 xul.dll mozilla::TaskQueue::Runner::Run() xpcom/threads/TaskQueue.cpp 12 xul.dll nsThreadPool::Run() xpcom/threads/nsThreadPool.cpp 13 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp 14 xul.dll NS_ProcessNextEvent(nsIThread*, bool) xpcom/glue/nsThreadUtils.cpp 15 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) ipc/glue/MessagePump.cpp 16 xul.dll MessageLoop::RunHandler() ipc/chromium/src/base/message_loop.cc 17 xul.dll MessageLoop::Run() ipc/chromium/src/base/message_loop.cc 18 xul.dll nsThread::ThreadFunc(void*) xpcom/threads/nsThread.cpp 19 nss3.dll _PR_NativeRunThread nsprpub/pr/src/threads/combined/pruthr.c 20 nss3.dll pr_root nsprpub/pr/src/md/windows/w95thred.c 21 msvcr120.dll _callthreadstartex f:\dd\vctools\crt\crtw32\startup\threadex.c:376 22 msvcr120.dll msvcr120.dll@0x2c000 23 kernel32.dll BaseThreadInitThunk 24 ntdll.dll __RtlUserThreadStart 25 ntdll.dll _RtlUserThreadStart this media related crash seems to have been newly introduced in firefox 43 and above. on 44.0b1 it's currently on #47 with 0.23% of all crashes, so it's not up in top crasher territory. this signature is showing up on windows and android so far.
It looks like we failed to create mThread so it was null. Not sure if it was due to low memory or xpcom shutdown.
Depends on: 948267
status-firefox46: ? → fixed
do you think, we can add something like a nullcheck here for firefox 45 (&esr)? - this is currently #20 top crash on beta.
Flags: needinfo?(jwwang)
The whole code of DecodedAudioDataSink depends on the fact that mThread is created successfully. Simply adding null-check doesn't give you a working DecodedAudioDataSink provided failing to create mThread successfully. We will just turn a crash into another obscure and confusing bug. The amount of work is not as big as bug 948267, but it is still non-trivial. We need a good reason to believe the amount of work is worth the #20 top crash.
Flags: needinfo?(jwwang)
ok, thanks for the info.
Crash volume for signature 'mozilla::media::DecodedAudioDataSink::DispatchTask': - nightly (version 50): 0 crash from 2016-06-06. - aurora (version 49): 0 crash from 2016-06-07. - beta (version 48): 0 crash from 2016-06-06. - release (version 47): 0 crash from 2016-05-31. - esr (version 45): 611 crashes from 2016-04-07. Crash volume on the last weeks: Week N-1 Week N-2 Week N-3 Week N-4 Week N-5 Week N-6 Week N-7 - nightly 0 0 0 0 0 0 0 - aurora 0 0 0 0 0 0 0 - beta 0 0 0 0 0 0 0 - release 0 0 0 0 0 0 0 - esr 84 62 63 68 76 51 38 Affected platform: Windows
status-firefox-esr45: --- → affected
We're still seeing these, but none are from a Firefox more recent than 45 esr. Looks like it's fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.