1234553 - Distorted sound in Facebook videos

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Silaghi, QA [:pauly]]

FF 43.0.2, Ubuntu 13.04 x86

STR:
1. Open https://www.facebook.com/DCompeticion/videos/980618211995705/
2. Listen

Actual results:
Sound is distorted

Expected results:
Sound should not be distorted.

Comment 1

[Paul Silaghi, QA [:pauly]]

Reproduces also on 46.0a1 (2015-12-22).
Doesn't reproduce on FF 42, ESR 38.5.2.

Comment 2

[Paul Silaghi, QA [:pauly]]

I reproduced the problem on 3 machines with Ubuntu 12.04 x86, Ubuntu 13.04 x86, Ubuntu 14.04 x64 - FF 43.0.2.
But couldn't reproduce on another Ubuntu 14.04 x86 machine - FF 43.0.2.
So, this is probably a hardware specific issue.

Comment 3

[Paul Silaghi, QA [:pauly]]

Regression range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9fa379806dd4a7bf9070ed269445c70b15a98c81&tochange=8ecae3736f32fa9cc88de5d5c009c89549af8e47

Comment 4

[Paul Silaghi, QA [:pauly]]

Attachment: distorted sound.ogg

Comment 5

[Jean-Yves Avenard [:jya]]

Please post the output of about:support and what version of ffmpeg you have installed. thank you

Comment 6

[Paul Silaghi, QA [:pauly]]

Attachment: about:support.txt

FFmpeg wasn't install.
The issue is still repro after install:
ffmpeg version 0.8.17-4:0.8.17-0ubuntu0.12.04.1

Comment 7

[Jean-Yves Avenard [:jya]]

can't reproduce on 15.10 (64 bits) with neither 43 nor nightly (ffmpeg 2.7.2)
can't reproduce on 14.04 (64 bits) with neither 43 nor nightly (LibAV 9.18)
can reproduce in 12.04 (64 bits) with 43 with LibAV 8

Did you restart firefox after installing ffmpeg? otherwise you would be using gstreamer.
what gstreamer do you have installed and what plugins?

Comment 8

[Jean-Yves Avenard [:jya]]

Attachment: Always request 16 bits audio for libavcodec 53.

LibAV 0.8 produces rubbish floating point data. We had restricted LibAV 0.8 to produce 16 bits audio instead, unfortunately some ubuntu version appears to have bumped the minor version.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b8e2290d460

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8701663 [details] [diff] [review]
Always request 16 bits audio for libavcodec 53.

Approval Request Comment
[Feature/regressing bug #]: 1234553
[User impact if declined]: Old distribution of linux shipping with LibAV 0.8 will play HE-AAC with bad audio. The effect is relatively dramatic. Even at the lowest value, if you're wearing a headset: it will cause physical pain (my ear are still ringing from listening to it for 1s over 30 minutes ago) and would likely damage the speakers
[Describe test coverage new/current, TreeHerder]: local test
[Risks and why]: None, we were already forcing a particular audio mode for this version of libav. Unfortunately, libav changed the minor version along the way bypassing our existing workaround.
[String/UUID change made/needed]: None

Seems this deserve a +.1 version... but I leave that up to you. We do not know how many installations are using that version of LibAV

Comment 11

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

This only affects Ubuntu 12.04 and HE-AAC. It does not affect YouTube because it doesn't use HE-AAC.

Comment 12

[Paul Silaghi, QA [:pauly]]

(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Did you restart firefox after installing ffmpeg?
Yes
> what gstreamer do you have installed and what plugins?
GStreamer extra plugins - gstreamer0.10-plugins-ugly 0.10.19-2
and
GStreamer ffmpeg video plugin - gstreamer0.10-ffmpeg 0.10.13-5

Comment 13

[Jean-Yves Avenard [:jya]]

So you had bad audio without ffmpeg installed and just gstreamer? Weird. But there's nothing we can do there.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b8e2290d460

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Paul, could you please verify this issue is fixed as expected on a latest version of Nightly? Thanks!

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8701663 [details] [diff] [review]
Always request 16 bits audio for libavcodec 53.

While this impacts only Ubuntu users, the issue is critical enough to fix in Beta44, Aurora45.

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef7943dc6f2f

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm hitting conflicts uplifting this to beta. Can we get a rebased patch for it?

Comment 19

[Jean-Yves Avenard [:jya]]

Attachment: patch for beta

Comment 20

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/44eb237f155a

Comment 21

[Carsten Book [:Tomcat]]

(In reply to Jean-Yves Avenard [:jya] from comment #20)
> remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/44eb237f155a

setting flags

Comment 22

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8701663 [details] [diff] [review]
Always request 16 bits audio for libavcodec 53.

Too late for 43.

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/44eb237f155a

Comment 24

[Paul Silaghi, QA [:pauly]]

(In reply to Ritu Kothari (:ritu) from comment #15)
> Paul, could you please verify this issue is fixed as expected on a latest
> version of Nightly? Thanks!
Verified fixed 46.0a1 (2016-01-03), 45.0a2 (2016-01-04) Ubuntu 12.04, Ubuntu 13.04.

Comment 25

[Paul Silaghi, QA [:pauly]]

Also verified fixed in FF 44b6, Ubuntu 13.04.